Skip to content

Moved dedicated hosts to the end of the resultset when selecting an e…#4428

Merged
DaanHoogland merged 8 commits into
apache:masterfrom
shapeblue:dedicated_hosts_priority
Nov 18, 2020
Merged

Moved dedicated hosts to the end of the resultset when selecting an e…#4428
DaanHoogland merged 8 commits into
apache:masterfrom
shapeblue:dedicated_hosts_priority

Conversation

@Spaceman1984

@Spaceman1984 Spaceman1984 commented Oct 27, 2020

Copy link
Copy Markdown
Contributor

…ndpoint

Description

When Cloudstack selects an endpoint to do various storage-related tasks, a dedicated host will be lower in priority.

Fixes: #3392

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Dedicate a host to an account and then call the prepareTemplate API - depending on your setup - if you have 2 hosts and the 1 is dedicated, the dedicated host should not do the seeding of the template.
If there is only 1 host, then it will do the seeding.

@yadvr yadvr closed this Oct 29, 2020
@yadvr yadvr reopened this Oct 29, 2020
@yadvr

yadvr commented Oct 29, 2020

Copy link
Copy Markdown
Member

@Spaceman1984 pl run packaging and test

@Spaceman1984

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2306

@yadvr yadvr added this to the 4.15.0.0 milestone Nov 2, 2020
@yadvr

yadvr commented Nov 2, 2020

Copy link
Copy Markdown
Member

@blueorangutan test centos7 vmware-67u3

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@yadvr yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did not test it

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-3115)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38645 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4428-t3115-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_03_deploy_and_upgrade_kubernetes_cluster Failure 778.36 test_kubernetes_clusters.py

@Spaceman1984

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2343

@Spaceman1984

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2385

@Spaceman1984 Spaceman1984 marked this pull request as draft November 16, 2020 09:54
@blueorangutan

Copy link
Copy Markdown

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2391

@Spaceman1984

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@Spaceman1984 Spaceman1984 marked this pull request as ready for review November 17, 2020 11:23
@blueorangutan

Copy link
Copy Markdown

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2392

@Spaceman1984

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2393

@Spaceman1984

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@DaanHoogland

Copy link
Copy Markdown
Contributor

@sureshanaparti can you check if your concerns are met? tnx

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-3188)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34275 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4428-t3188-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@DaanHoogland DaanHoogland merged commit acee15a into apache:master Nov 18, 2020
@DaanHoogland DaanHoogland deleted the dedicated_hosts_priority branch November 18, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dedicate VMware hosts are still used for template seeding

6 participants