vmware: disk controller fix

[Spaceman1984]

Description

Fixes: #4344

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Change the disk controller setting while the instance is stopped.
Start the instance.
Check vSphere client for disk controller change.

[Spaceman1984]

@blueorangutan package

[blueorangutan]

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2249

[shwstppr]

Reopening to address the issue in 4.14

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2643

[shwstppr]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-3483)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36714 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4416-t3483-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Smoke tests completed. 80 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_04_change_offering_small	Error	5.34	test_service_offerings.py
test_02_create_template_with_checksum_sha1	Error	5.23	test_templates.py
test_03_create_template_with_checksum_sha256	Error	5.22	test_templates.py
test_04_create_template_with_checksum_md5	Error	5.23	test_templates.py
test_change_service_offering_for_vm_with_snapshots	Error	150.22	test_vm_snapshots.py

[harikrishna-patnala]

code looks good to me, hope you have tested with both deploy as is VMs and usual VMs!
I'll do quick test and update.

[shwstppr]

On 4.14 fix looks good but with forward merge on 4.15 (https://github.com/shapeblue/cloudstack/tree/disk-controller-vmware-415), with new template (deploy-as-is), change of controller doesn't reflect at vCenter side.
I upgraded a 4.14 env to 4.15 to test both old and new templates
This will need a bit more testing and some fixes.
Better to move it to 4.14.2 or 4.15.1? @rhtyd @harikrishna-patnala

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ centos7 ✔️ debian. SL-JID 459

[shwstppr]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-529)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34470 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4416-t529-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_10_traceroute_in_vr	Failure	61.12	test_diagnostics.py

[yadvr]

ping @Spaceman1984 cc @harikrishna-patnala

[Spaceman1984]

Raised #5006 PR to fix #4344