Skip to content

CKS : More log changes from uuid to name#4415

Merged
DaanHoogland merged 1 commit into
apache:masterfrom
shapeblue:cks-log
Oct 27, 2020
Merged

CKS : More log changes from uuid to name#4415
DaanHoogland merged 1 commit into
apache:masterfrom
shapeblue:cks-log

Conversation

@davidjumani

@davidjumani davidjumani commented Oct 20, 2020

Copy link
Copy Markdown
Contributor

Description

Changing log details from cluster / node UUID to name
Add-on to #4411

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no comments

@davidjumani davidjumani marked this pull request as ready for review October 22, 2020 05:01
@davidjumani

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2258

@davidjumani

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-3043)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38178 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4415-t3043-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 85 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@shwstppr shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaanHoogland

Copy link
Copy Markdown
Contributor

trivial changes, test is by merit of the smoke tests.

@DaanHoogland DaanHoogland merged commit 86f2b79 into apache:master Oct 27, 2020
@DaanHoogland DaanHoogland deleted the cks-log branch October 27, 2020 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants