Skip to content

Hiding system reserved IP addresses#4408

Merged
yadvr merged 1 commit into
apache:masterfrom
shapeblue:hide-system-reserved-ips
Nov 2, 2020
Merged

Hiding system reserved IP addresses#4408
yadvr merged 1 commit into
apache:masterfrom
shapeblue:hide-system-reserved-ips

Conversation

@Spaceman1984

@Spaceman1984 Spaceman1984 commented Oct 15, 2020

Copy link
Copy Markdown
Contributor

Description

This PR removes system reserved IP addresses from the options of acquiring IP addresses. Choosing any reserved IP address results in an error. The IP addresses should not have been displayed in the first place.

Fixes: #4310

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Add a public IP address range and dedicate it to system VMs.
Acquire new IP addresses - the system VM dedicated IP addresses should not be in the list.

@Spaceman1984

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2184

@Spaceman1984

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-2963)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33284 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4408-t2963-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 84 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_hostha_kvm_host_fencing Error 166.29 test_hostha_kvm.py

@GabrielBrascher GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr yadvr merged commit 18e8375 into apache:master Nov 2, 2020
Pearl1594 pushed a commit to shapeblue/cloudstack that referenced this pull request Nov 4, 2020
This PR removes system reserved IP addresses from the options of acquiring IP addresses. Choosing any reserved IP address results in an error. The IP addresses should not have been displayed in the first place.

Fixes: apache#4310
Pearl1594 pushed a commit to shapeblue/cloudstack that referenced this pull request Nov 4, 2020
This PR removes system reserved IP addresses from the options of acquiring IP addresses. Choosing any reserved IP address results in an error. The IP addresses should not have been displayed in the first place.

Fixes: apache#4310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SystemVMs Publics IPs offered to accounts despite global settings

7 participants