Skip to content

Fix stg access group validation#13562

Draft
Pearl1594 wants to merge 4 commits into
4.22from
fix-stg-access-group-validation
Draft

Fix stg access group validation#13562
Pearl1594 wants to merge 4 commits into
4.22from
fix-stg-access-group-validation

Conversation

@Pearl1594

Copy link
Copy Markdown
Contributor

Description

The PR fixes the below issue:

VM migration fails with “Storage access groups on the source and destination hosts did not match” if list of storage access groups does not match.

Steps to reproduce:

VM with ROOT volume ed2 (Volume Type ACED) created on Host with storage access groups [legacy, aced]
VM migrated to Host with storage access groups [aced]

Expected result:
VM migrated as there is common storage access group, where ROOT volume created from (aced).

Observed result:
Storage access groups on the source and destination hosts did not match.
It just simply checks collections [legacy, aced] and [aced] should be equal.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sachindoddaguni and others added 2 commits July 7, 2026 11:51
* VM Migration: Storage access groups validation issue fix

* Refactor list empty checks

---------

Co-authored-by: Sachin R Doddaguni <s_rudrappadoddagu@apple.com>
@Pearl1594 Pearl1594 marked this pull request as draft July 7, 2026 15:55
@Pearl1594 Pearl1594 requested a review from nvazquez July 7, 2026 15:55
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.69%. Comparing base (a951ac6) to head (f14f9dd).

❗ There is a different number of reports uploaded between BASE (a951ac6) and HEAD (f14f9dd). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a951ac6) HEAD (f14f9dd)
unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               4.22   #13562       +/-   ##
=============================================
- Coverage     17.67%    3.69%   -13.98%     
=============================================
  Files          5923      448     -5475     
  Lines        533349    38117   -495232     
  Branches      65248     7067    -58181     
=============================================
- Hits          94253     1409    -92844     
+ Misses       428437    36521   -391916     
+ Partials      10659      187    -10472     
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants