Improve VMware import guest OS detection#13269
Open
andrijapanicsb wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13269 +/- ##
============================================
+ Coverage 18.10% 18.12% +0.01%
- Complexity 16749 16776 +27
============================================
Files 6037 6037
Lines 542796 542914 +118
Branches 66456 66495 +39
============================================
+ Hits 98268 98378 +110
+ Misses 433492 433484 -8
- Partials 11036 11052 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: andrijapanicsb <45762285+andrijapanicsb@users.noreply.github.com>
andrijapanicsb
force-pushed
the
improve-vm-import-guest-os-recognition
branch
from
bb37ba6 to
bbe7804
Compare
Contributor
Author
|
@blueorangutan package kvm |
|
@andrijapanicsb a [SL] Jenkins job has been kicked to build packages. It will be bundled with kvm SystemVM template(s). I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 18076 |
Contributor
Author
|
@blueorangutan test keepEnv |
|
@andrijapanicsb a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This improves guest OS detection for VMware-to-KVM VM imports.
VMware can expose two different OS signals for a VM: the configured guest OS identifier, such as
otherLinux64Guest, and the runtime/display OS name reported by VMware Tools, such asDebian GNU/Linux 11 (64-bit). The configured identifier can be generic, while the runtime OS name is often more accurate.(this is exactly the case with systemVM (VR or CPVM or SSVM) which I tried to migrate from another ACS/VMware installation from VMware 7.0 U3)
This change updates the import flow to prefer the more specific runtime/display OS name when resolving CloudStack guest OS mappings, while keeping the existing VMware guest OS identifier lookup as the compatibility fallback.
Details
The guest OS lookup now tries:
If none of these produce a match, the existing fallback behavior remains unchanged.
The same resolution is also applied server-side when
osidis not explicitly supplied, so API callers and UI-driven imports follow the same guest OS selection behavior.Benefit
This avoids falling back to the default import template OS when VMware Tools already reports a precise guest OS name. For example, a VM configured in vSphere as
Other Linux (64-bit)but reported by VMware Tools asDebian GNU/Linux 11 (64-bit)can now resolve to the correct CloudStack guest OS when a matching OS or mapping exists.Testing