Introduce Quota resource statement API by winterhazel · Pull Request #13236 · apache/cloudstack

winterhazel · 2026-05-25T18:27:55Z

Description

This PR introduces the quotaResourceStatement API to the Quota plugin. This API allows viewing the Quota consumption associated with a specific resource. It will be used by the Quota UI rework in a separate PR.

In addition, some adjustments were made in the quotaStatement API in order to allow including the consumption of subdomains in the resulting statement.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

How Has This Been Tested?

I tested the API by fuzzing its parameters for root admin, domain admin, and user accounts. In the tests, I validated that the API returned the expected response while performing correct permission checking.

Environment configuration

My environment had two domains: ROOT and d1.

MariaDB [cloud]> select uuid,name,path,parent from domain;
+--------------------------------------+------+------+--------+
| uuid                                 | name | path | parent |
+--------------------------------------+------+------+--------+
| de3f3dfb-f84b-11f0-8ace-32e0826870ba | ROOT | /    |   NULL |
| dc5064ad-d4a8-4bb3-ae18-a52e4810ac3d | d1   | /d1/ |      1 |
+--------------------------------------+------+------+--------+

Each domain had a domain admin (dr for ROOT and d1 for d1) and a user account (ur for ROOT and u1 for d1). ROOT also had a project and the root admin.

MariaDB [cloud]> select uuid,account_name,domain_id,role_id from account;
+--------------------------------------+--------------------------+-----------+---------+
| uuid                                 | account_name             | domain_id | role_id |
+--------------------------------------+--------------------------+-----------+---------+
| f684aae8-f84b-11f0-8ace-32e0826870ba | system                   |         1 |       1 |
| f684da1a-f84b-11f0-8ace-32e0826870ba | admin                    |         1 |       1 |
| 17dfdcce-fd02-46d0-85ae-7de91fda634c | baremetal-system-account |         1 |       4 |
| aaba75a0-a575-41be-80e1-dbea14c10e51 | dr                       |         1 |       3 |
| feaffae2-7ba4-45dc-b46f-20ae86192685 | d1                       |         2 |       3 |
| 2f49212d-d6d5-437b-800d-a7bb4a8def4b | u1                       |         2 |       4 |
| b029e8b8-e539-4d1a-906d-3d4f2fb36b82 | ur                       |         1 |       4 |
| b14100c6-d9f6-450e-87a2-0833bb45e5f8 | PrjAcct-aa-1             |         1 |    NULL |
+--------------------------------------+--------------------------+-----------+---------+

Test 1 (user accounts)

id: returns the statement scoped to the owning account when the caller has access to it, and an error when it does not.

 (u1) 🐱 > quota resourcestatement id=53c791d2-ac8f-4acb-9246-3a2b9eb354ea startdate=2026-01-01 enddate=2027-01-01 usagetype=1
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "2f49212d-d6d5-437b-800d-a7bb4a8def4b",
 	"enddate": "2026-05-24T20:59:59-0300",
 	"quotaconsumed": 2.46531524,
 	"startdate": "2026-05-23T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 5.69112164,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }

 (u1) 🐱 > quota resourcestatement id=e4e91818-cbb5-401a-bb42-35d976ea4e01 startdate=2026-01-01 enddate=2027-01-01 usagetype=1
 🙈 Error: (HTTP 531, error code 4365) Caller does not have permission to operate with provided resource.

accountid: returns the statement scoped to the provided account if accessible, or an empty list otherwise.

 (u1) 🐱 > quota resourcestatement id=53c791d2-ac8f-4acb-9246-3a2b9eb354ea startdate=2026-01-01 enddate=2027-01-01 usagetype=1 accountid=2f49212d-d6d5-437b-800d-a7bb4a8def4b (u1)
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "2f49212d-d6d5-437b-800d-a7bb4a8def4b",
 	"enddate": "2026-05-24T20:59:59-0300",
 	"quotaconsumed": 2.46531524,
 	"startdate": "2026-05-23T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 5.69112164,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }

 (u1) 🐱 > quota resourcestatement id=e4e91818-cbb5-401a-bb42-35d976ea4e01 startdate=2026-01-01 enddate=2027-01-01 usagetype=1 accountid=2f49212d-d6d5-437b-800d-a7bb4a8def4b (u1)
 {
   "quotaresourcestatement": {
     "items": [],
     "totalquota": 0,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }

projectid: returns the statement scoped to the provided project if accessible, or an exception otherwise.

 (u1) 🐱 > quota resourcestatement id=6d7b3c73-7f06-4f23-9210-3af5889790d1 startdate=2026-01-01 enddate=2027-01-01 usagetype=1 projectid=c1ce41c4-7b01-4386-8264-479db5ace0bc
 🙈 Error: (HTTP 432, error code 9999) The API [quotaResourceStatement] does not exist or is not available for this account/user in project [c1ce41c4-7b01-4386-8264-479db5ace0bc].

 (ur) 🐱 > quota resourcestatement id=6d7b3c73-7f06-4f23-9210-3af5889790d1 startdate=2026-01-01 enddate=2027-01-01 usagetype=1 projectid=c1ce41c4-7b01-4386-8264-479db5ace0bc
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "b14100c6-d9f6-450e-87a2-0833bb45e5f8",
 	"enddate": "2026-05-21T20:59:59-0300",
 	"quotaconsumed": 1.42573923,
 	"startdate": "2026-05-20T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 22.20631686,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }

isrecursive: ignored for user accounts.

 (ur) 🐱 > quota resourcestatement id=db0db635-df4d-42bb-9aca-19cc3d986ca0 startdate=2026-01-01 enddate=2027-01-01 usagetype=1 isrecursive=true
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "b029e8b8-e539-4d1a-906d-3d4f2fb36b82",
 	"enddate": "2026-05-24T20:59:59-0300",
 	"quotaconsumed": 2.46247754,
 	"startdate": "2026-05-23T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 18.9019186,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }
 (ur) 🐱 > quota resourcestatement id=db0db635-df4d-42bb-9aca-19cc3d986ca0 startdate=2026-01-01 enddate=2027-01-01 usagetype=1 isrecursive=false
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "b029e8b8-e539-4d1a-906d-3d4f2fb36b82",
 	"enddate": "2026-05-24T20:59:59-0300",
 	"quotaconsumed": 2.46247754,
 	"startdate": "2026-05-23T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 18.9019186,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }

Test 2 (domain admins)

id: returns the statement scoped to the caller's domain.

 (d1) 🐱 > quota resourcestatement id=53c791d2-ac8f-4acb-9246-3a2b9eb354ea startdate=2026-01-01 enddate=2027-01-01 usagetype=1
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "2f49212d-d6d5-437b-800d-a7bb4a8def4b",
 	"enddate": "2026-05-24T20:59:59-0300",
 	"quotaconsumed": 2.46531524,
 	"startdate": "2026-05-23T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 14.60737768,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }

 (d1) 🐱 > quota resourcestatement id=db0db635-df4d-42bb-9aca-19cc3d986ca0 startdate=2026-01-01 enddate=2027-01-01 usagetype=1
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "2f49212d-d6d5-437b-800d-a7bb4a8def4b",
 	"enddate": "2026-05-21T20:59:59-0300",
 	"quotaconsumed": 1.42775528,
 	"startdate": "2026-05-20T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 25.15400928,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }

 (d1) 🐱 > quota resourcestatement id=6d7b3c73-7f06-4f23-9210-3af5889790d1 startdate=2026-01-01 enddate=2027-01-01 usagetype=1
 {
   "quotaresourcestatement": {
     "items": [],
     "totalquota": 0,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }

accountid: returns the statement scoped to the provided account if accessible, or an exception otherwise.

 (d1) 🐱 > quota resourcestatement id=53c791d2-ac8f-4acb-9246-3a2b9eb354ea startdate=2026-01-01 enddate=2027-01-01 usagetype=1 accountid=2f49212d-d6d5-437b-800d-a7bb4a8def4b
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "2f49212d-d6d5-437b-800d-a7bb4a8def4b",
 	"enddate": "2026-05-24T20:59:59-0300",
 	"quotaconsumed": 2.46531524,
 	"startdate": "2026-05-23T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 11.44631141,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }

 (d1) 🐱 > quota resourcestatement id=53c791d2-ac8f-4acb-9246-3a2b9eb354ea startdate=2026-01-01 enddate=2027-01-01 usagetype=1 accountid=feaffae2-7ba4-45dc-b46f-20ae86192685 
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "feaffae2-7ba4-45dc-b46f-20ae86192685",
 	"enddate": "2026-05-26T20:59:59-0300",
 	"quotaconsumed": 3.16106627,
 	"startdate": "2026-05-25T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       }
     ],
     "totalquota": 3.16106627,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }

 (d1) 🐱 > quota resourcestatement id=53c791d2-ac8f-4acb-9246-3a2b9eb354ea startdate=2026-01-01 enddate=2027-01-01 usagetype=1 accountid=f684da1a-f84b-11f0-8ace-32e0826870ba
 🙈 Error: (HTTP 531, error code 4365) Caller does not have permission to operate with provided resource.

projectid: returns the statement scoped to the provided project if accessible, or an exception otherwise.

 (d1) 🐱 > quota resourcestatement id=6d7b3c73-7f06-4f23-9210-3af5889790d1 startdate=2026-01-01 enddate=2027-01-01 usagetype=1 projectid=c1ce41c4-7b01-4386-8264-479db5ace0bc
 🙈 Error: (HTTP 531, error code 4365) Account Account [{"accountName":"d1","id":5,"uuid":"feaffae2-7ba4-45dc-b46f-20ae86192685"}] does not have permission to operate within domain id=de3f3dfb-f84b-11f0-8ace-32e0826870ba

 (dr) 🐱 > quota resourcestatement id=6d7b3c73-7f06-4f23-9210-3af5889790d1 startdate=2026-01-01 enddate=2027-01-01 usagetype=1 projectid=c1ce41c4-7b01-4386-8264-479db5ace0bc
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "b14100c6-d9f6-450e-87a2-0833bb45e5f8",
 	"enddate": "2026-05-21T20:59:59-0300",
 	"quotaconsumed": 1.42573923,
 	"startdate": "2026-05-20T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 39.76108809,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }

isrecursive: allows domain admins to generate the statement including usage records of subdomains.

 (dr) 🐱 > quota resourcestatement id=e4e91818-cbb5-401a-bb42-35d976ea4e01 startdate=2026-01-01 enddate=2027-01-01 usagetype=1 isrecursive=true
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "f684da1a-f84b-11f0-8ace-32e0826870ba",
 	"enddate": "2026-05-21T20:59:59-0300",
 	"quotaconsumed": 1.42880073,
 	"startdate": "2026-05-20T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 52.70616739,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }
 (dr) 🐱 > quota resourcestatement id=e4e91818-cbb5-401a-bb42-35d976ea4e01 startdate=2026-01-01 enddate=2027-01-01 usagetype=1 isrecursive=false
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "f684da1a-f84b-11f0-8ace-32e0826870ba",
 	"enddate": "2026-05-21T20:59:59-0300",
 	"quotaconsumed": 1.42880073,
 	"startdate": "2026-05-20T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 33.79573569,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }

Test 3 (root admins)

id: returns the statement of any resource without limiting.

 (admin) 🐱 > quota resourcestatement id=e4e91818-cbb5-401a-bb42-35d976ea4e01 startdate=2026-01-01 enddate=2027-01-01 usagetype=1
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "f684da1a-f84b-11f0-8ace-32e0826870ba",
 	"enddate": "2026-05-21T20:59:59-0300",
 	"quotaconsumed": 1.42880073,
 	"startdate": "2026-05-20T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 39.76534465,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }
 (admin) 🐱 > quota resourcestatement id=ab6b1ced-d36e-4436-aad2-e78e06005350 startdate=2026-01-01 enddate=2027-01-01 usagetype=1
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "feaffae2-7ba4-45dc-b46f-20ae86192685",
 	"enddate": "2026-05-21T20:59:59-0300",
 	"quotaconsumed": 1.42801677,
 	"startdate": "2026-05-20T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 39.76291791,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }
 (admin) 🐱 > quota resourcestatement id=db0db635-df4d-42bb-9aca-19cc3d986ca0 startdate=2026-01-01 enddate=2027-01-01 usagetype=1
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "2f49212d-d6d5-437b-800d-a7bb4a8def4b",
 	"enddate": "2026-05-21T20:59:59-0300",
 	"quotaconsumed": 1.42775528,
 	"startdate": "2026-05-20T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 39.75638356,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }
 (admin) 🐱 > quota resourcestatement id=53c791d2-ac8f-4acb-9246-3a2b9eb354ea startdate=2026-01-01 enddate=2027-01-01 usagetype=1
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "b029e8b8-e539-4d1a-906d-3d4f2fb36b82",
 	"enddate": "2026-05-21T20:59:59-0300",
 	"quotaconsumed": 1.42670996,
 	"startdate": "2026-05-20T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 39.7583256,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }

accountid: returns the statement scoped to the provided account.

 (admin) 🐱 > quota resourcestatement id=53c791d2-ac8f-4acb-9246-3a2b9eb354ea startdate=2026-01-01 enddate=2027-01-01 usagetype=1 accountid=2f49212d-d6d5-437b-800d-a7bb4a8def4b
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "2f49212d-d6d5-437b-800d-a7bb4a8def4b",
 	"enddate": "2026-05-24T20:59:59-0300",
 	"quotaconsumed": 2.46531524,
 	"startdate": "2026-05-23T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 11.44631141,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }

 (admin) 🐱 > quota resourcestatement id=53c791d2-ac8f-4acb-9246-3a2b9eb354ea startdate=2026-01-01 enddate=2027-01-01 usagetype=1 accountid=feaffae2-7ba4-45dc-b46f-20ae86192685
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "feaffae2-7ba4-45dc-b46f-20ae86192685",
 	"enddate": "2026-05-26T20:59:59-0300",
 	"quotaconsumed": 3.16106627,
 	"startdate": "2026-05-25T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       }
     ],
     "totalquota": 3.16106627,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }

 (admin) 🐱 > quota resourcestatement id=53c791d2-ac8f-4acb-9246-3a2b9eb354ea startdate=2026-01-01 enddate=2027-01-01 usagetype=1 accountid=f684da1a-f84b-11f0-8ace-32e0826870ba
 {
   "quotaresourcestatement": {
     "items": [],
     "totalquota": 0,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }

projectid: returns the statement scoped to the provided project.

 (admin) 🐱 > quota resourcestatement id=6d7b3c73-7f06-4f23-9210-3af5889790d1 startdate=2026-01-01 enddate=2027-01-01 usagetype=1 projectid=c1ce41c4-7b01-4386-8264-479db5ace0bc
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "b14100c6-d9f6-450e-87a2-0833bb45e5f8",
 	"enddate": "2026-05-21T20:59:59-0300",
 	"quotaconsumed": 1.42573923,
 	"startdate": "2026-05-20T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 39.76108809,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }

isrecursive: allows admins to generate the statement including usage records of subdomains.

 (admin) 🐱 > quota resourcestatement id=e4e91818-cbb5-401a-bb42-35d976ea4e01 startdate=2026-01-01 enddate=2027-01-01 usagetype=1
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "f684da1a-f84b-11f0-8ace-32e0826870ba",
 	"enddate": "2026-05-21T20:59:59-0300",
 	"quotaconsumed": 1.42880073,
 	"startdate": "2026-05-20T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 33.79573569,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }
 (admin) 🐱 > quota resourcestatement id=e4e91818-cbb5-401a-bb42-35d976ea4e01 startdate=2026-01-01 enddate=2027-01-01 usagetype=1 isrecursive=true
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "f684da1a-f84b-11f0-8ace-32e0826870ba",
 	"enddate": "2026-05-21T20:59:59-0300",
 	"quotaconsumed": 1.42880073,
 	"startdate": "2026-05-20T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 52.70616739,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }
 (admin) 🐱 > quota resourcestatement id=e4e91818-cbb5-401a-bb42-35d976ea4e01 startdate=2026-01-01 enddate=2027-01-01 usagetype=1 isrecursive=false
 {
   "quotaresourcestatement": {
     "items": [
       {
 	"accountid": "f684da1a-f84b-11f0-8ace-32e0826870ba",
 	"enddate": "2026-05-21T20:59:59-0300",
 	"quotaconsumed": 1.42880073,
 	"startdate": "2026-05-20T21:00:00-0300",
 	"tariffid": "2b9671f8-a0ec-4127-bcc8-69413375c3c6",
 	"tariffname": "RUNNING_VM"
       },
       ...
     ],
     "totalquota": 33.79573569,
     "unit": "Compute*Month",
     "usagename": "RUNNING_VM"
   }
 }

winterhazel · 2026-05-25T18:28:36Z

@blueorangutan package

codecov · 2026-05-25T18:44:04Z

Codecov Report

❌ Patch coverage is 46.78112% with 124 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.11%. Comparing base (a0aafe2) to head (dd8a848).
⚠️ Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
...udstack/api/command/QuotaResourceStatementCmd.java	0.00%	32 Missing ⚠️
...udstack/api/response/QuotaResponseBuilderImpl.java	63.29%	29 Missing ⚠️
...i/response/QuotaResourceStatementItemResponse.java	0.00%	21 Missing ⚠️
.../org/apache/cloudstack/quota/QuotaManagerImpl.java	63.41%	14 Missing and 1 partial ⚠️
...k/api/response/QuotaResourceStatementResponse.java	0.00%	15 Missing ⚠️
...he/cloudstack/quota/dao/QuotaUsageJoinDaoImpl.java	0.00%	4 Missing ⚠️
...g/apache/cloudstack/quota/constant/QuotaTypes.java	91.42%	3 Missing ⚠️
...ache/cloudstack/api/command/QuotaStatementCmd.java	0.00%	3 Missing ⚠️
.../org/apache/cloudstack/quota/QuotaServiceImpl.java	33.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13236      +/-   ##
============================================
+ Coverage     18.10%   18.11%   +0.01%     
- Complexity    16746    16773      +27     
============================================
  Files          6037     6040       +3     
  Lines        542933   543004      +71     
  Branches      66487    66476      -11     
============================================
+ Hits          98283    98388     +105     
+ Misses       433602   433568      -34     
  Partials      11048    11048

Flag	Coverage Δ
uitests	`3.51% <ø> (ø)`
unittests	`19.28% <46.78%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland · 2026-05-26T13:20:59Z

@blueorangutan package

blueorangutan · 2026-05-26T13:22:05Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-26T14:02:55Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18042

DaanHoogland · 2026-05-26T17:17:48Z

@blueorangutan test

blueorangutan · 2026-05-26T17:20:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-05-27T09:33:16Z

[SF] Trillian test result (tid-16186)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55395 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13236-t16186-kvm-ol8.zip
Smoke tests completed. 151 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2026-05-27T12:30:51Z

@winterhazel , I can review, but you probably have someone more knowledgeable to look at this...

winterhazel · 2026-05-27T18:03:37Z

@winterhazel , I can review, but you probably have someone more knowledgeable to look at this...

@DaanHoogland I already asked some people that are familiar with Quota to review this one, but feel free to review as well if you want to. Your reviews would still be appreciated :)

winterhazel · 2026-05-27T19:39:26Z

@blueorangutan package

blueorangutan · 2026-05-27T19:40:04Z

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-27T19:58:21Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 18067

winterhazel · 2026-05-28T00:46:04Z

@blueorangutan package

blueorangutan · 2026-05-28T00:48:04Z

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-05-28T01:38:53Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18069

DaanHoogland

code looks generally good, a few questions only.

winterhazel added 2 commits May 25, 2026 14:49

Introduce Quota resource statement API

af17bc9

Merge remote-tracking branch 'origin/main' into quota-statement-details

12ef94b

boring-cyborg Bot added component:api component:quota labels May 25, 2026

winterhazel requested a review from bernardodemarco May 25, 2026 18:28

winterhazel assigned gp-santos, JoaoJandre and erikbocks May 25, 2026

winterhazel unassigned gp-santos, JoaoJandre and erikbocks May 25, 2026

winterhazel requested review from JoaoJandre, erikbocks and gp-santos May 25, 2026 18:29

Fix pre-commit

b0ba9a1

Add additional unit tests

d6e7a9f

GaOrtiga reviewed May 27, 2026

View reviewed changes

Comment thread framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaManagerImpl.java Outdated

Persist all Quota usage related entries inside the same transaction

f3feb29

Fix checkstyle

dd8a848

DaanHoogland reviewed May 28, 2026

View reviewed changes

Conversation

winterhazel commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

How Has This Been Tested?

Environment configuration

Test 1 (user accounts)

Test 2 (domain admins)

Test 3 (root admins)

Uh oh!

winterhazel commented May 25, 2026

Uh oh!

codecov Bot commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DaanHoogland commented May 26, 2026

Uh oh!

blueorangutan commented May 26, 2026

Uh oh!

blueorangutan commented May 26, 2026

Uh oh!

DaanHoogland commented May 26, 2026

Uh oh!

blueorangutan commented May 26, 2026

Uh oh!

blueorangutan commented May 27, 2026

Uh oh!

DaanHoogland commented May 27, 2026

Uh oh!

winterhazel commented May 27, 2026

Uh oh!

Uh oh!

winterhazel commented May 27, 2026

Uh oh!

blueorangutan commented May 27, 2026

Uh oh!

blueorangutan commented May 27, 2026

Uh oh!

winterhazel commented May 28, 2026

Uh oh!

blueorangutan commented May 28, 2026

Uh oh!

blueorangutan commented May 28, 2026

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

winterhazel commented May 25, 2026 •

edited

Loading

codecov Bot commented May 25, 2026 •

edited

Loading