Clarify KVM import template requirement#13126
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13126 +/- ##
============================================
+ Coverage 18.09% 18.46% +0.36%
- Complexity 16721 17263 +542
============================================
Files 6037 6037
Lines 542546 553970 +11424
Branches 66431 70938 +4507
============================================
+ Hits 98159 102275 +4116
- Misses 433368 440467 +7099
- Partials 11019 11228 +209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package kvm |
|
@andrijapanicsb a [SL] Jenkins job has been kicked to build packages. It will be bundled withkvm SystemVM template(s). I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17772 |
|
@blueorangutan test |
|
@andrijapanicsb a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
@blueorangutan test ol8 kvm-ol8 keepEnv |
|
@blueorangutan test |
|
@andrijapanicsb a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-16173)
|
| Parameter parameter = templateIdField.getAnnotation(Parameter.class); | ||
|
|
||
| Assert.assertNotNull(parameter); | ||
| Assert.assertTrue(parameter.description().contains("Required when importing an unmanaged KVM Instance.")); |
There was a problem hiding this comment.
this is testing static code. not sure if we need this test.
nvazquez
left a comment
nvazquez
left a comment
There was a problem hiding this comment.
@andrijapanicsb the text on the description looks good, IMO the API must also check the hypervisor type and the importing operation and fail in case it is not passed for KVM import unmanaged instance.
| Parameter parameter = templateIdField.getAnnotation(Parameter.class); | ||
|
|
||
| Assert.assertNotNull(parameter); | ||
| Assert.assertTrue(parameter.description().contains("Required when importing an unmanaged KVM Instance.")); |
…mportUnmanagedInstanceCmdTest.java unneeded
In the UI for Migrating from VMware to KVM etc - there is no option to even select a template - seems we always (or UI does ot) assign the dummy template 
|
|
4 participants
Description
importUnmanagedInstancedocumentstemplateidas an optional parameter, but KVM unmanaged instance import currently requires a template and fails when one is not supplied.This updates the generated API parameter description for
templateidto explicitly mention that it is required when importing an unmanaged KVM instance. It avoids the current mismatch between API docs and runtime behavior without changing import semantics.Fixes #13067
Tests
Added
ImportUnmanagedInstanceCmdTestcoverage to verify thetemplateidAPI parameter description includes the KVM requirement. Deleted