Closed
Add batch mode API for efficient mass policy operations#522
Conversation
|
|
Co-authored-by: mserico <140243407+mserico@users.noreply.github.com>
Co-authored-by: mserico <140243407+mserico@users.noreply.github.com>
Co-authored-by: mserico <140243407+mserico@users.noreply.github.com>
Co-authored-by: mserico <140243407+mserico@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix unpredictable behavior in Casbin on mass updates
Add batch mode API for efficient mass policy operations
Dec 8, 2025
mserico
marked this pull request as ready for review
December 8, 2025 14:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mass policy operations (thousands of
removePolicy()/removeGroupingPolicy()calls) cause severe performance degradation because each operation triggers database write, role link rebuild, and watcher notification. Users were also unnecessarily callingloadPolicy()after each modification, compounding the problem.Changes
New Batch Mode API
startBatch(): Suspends autoSave, autoBuildRoleLinks, and autoNotifyWatcherendBatch(): Restores settings, performs single save and role link rebuildsavePolicy()gracefullyDocumentation
loadPolicy()is unnecessary after modifications when autoSave is enabledUsage
Performance improvement: O(N) → O(1) for N policy operations.
100% backward compatible - existing code unaffected.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.