Closed
Conversation
|
|
nomeguy
marked this pull request as ready for review
November 1, 2025 09:19
Co-authored-by: nomeguy <85475922+nomeguy@users.noreply.github.com>
Co-authored-by: nomeguy <85475922+nomeguy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add functionality to auto-load policies from database on startup
Add LoadPolicy API for database adapters
Nov 1, 2025
|
@nomeguy please merge this issue as well :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EctoAdapter auto-saves policies to the database but provided no built-in way to load them back on startup, forcing manual database queries and policy reconstruction.
Changes
Added overloaded functions to load from configured adapter:
EnforcerServer.load_policies/1- loads policies without requiring file pathEnforcerServer.load_mapping_policies/1- loads role mappings without requiring file pathThese leverage existing
Enforcer.load_policies!/1andEnforcer.load_mapping_policies!/1, exposing adapter-based loading at the server level.Backward compatible:
load_policies/2,load_mapping_policies/2) unchangedUsage
Before:
After:
Implements LoadPolicy API pattern per maintainer feedback.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.