Skip to content

feat: fix RBAC role inheritance with domains #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsluoyz merged 5 commits into from
Oct 30, 2025
+5 −5
Merged

feat: fix RBAC role inheritance with domains #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6ff1663
Initial plan
Copilot Oct 29, 2025
6d3cdf8
Fix role-to-role inheritance with domains
Copilot Oct 29, 2025
ac2e74d
Add test case reproducing exact issue scenario
Copilot Oct 29, 2025
4712026
Add test matching Golang Casbin implementation
Copilot Oct 30, 2025
cdbf033
Remove custom test file to match Golang Casbin test structure
Copilot Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/acx/enforcer.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ defmodule Acx.Enforcer do
when is_atom(mapping_name) and is_binary(role1) and is_binary(role2) and is_binary(dom) do
with group when not is_nil(group) <- Map.get(groups, mapping_name),
false <- Enum.member?(mappings, mapping),
group <- RoleGroup.add_inheritance(group, {role1, role2 <> dom}) do
group <- RoleGroup.add_inheritance(group, {{role1, dom}, {role2, dom}}) do
new_enforcer = %{
enforcer
| role_groups: %{groups | mapping_name => group},
Expand Down Expand Up @@ -720,7 +720,7 @@ defmodule Acx.Enforcer do
)
when is_atom(mapping_name) and is_binary(role1) and is_binary(role2) and is_binary(dom) do
with group when not is_nil(group) <- Map.get(groups, mapping_name),
group <- RoleGroup.remove_inheritance(group, {role1, role2 <> dom}),
group <- RoleGroup.remove_inheritance(group, {{role1, dom}, {role2, dom}}),
mappings <- Enum.reject(mappings, fn m -> m == mapping end),
{:ok, _adpater} <-
PersistAdapter.remove_policy(adapter, {mapping_name, [role1, role2, dom]}) do
Expand Down
6 changes: 3 additions & 3 deletions lib/acx/internal/role_group.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,9 @@ defmodule Acx.Internal.RoleGroup do
...> false = f.(1, 2)
...> f.("admin", "member")
true
...> g = g |> RoleGroup.add_inheritance({"admin", "memberdomain"})
...> g = g |> RoleGroup.add_inheritance({{"admin", "domain"}, {"member", "domain"}})
...> f = g |> RoleGroup.stub_3
...> false = f.("member", "admin", "dom")
...> false = f.("member", "admin", "domain")
...> f.("admin", "member", "domain")
true
"""
Expand All @@ -161,7 +161,7 @@ defmodule Acx.Internal.RoleGroup do
def stub_3(%__MODULE__{} = group) do
fn
arg1, arg2, arg3 ->
group |> inherit_from?(arg1, arg2 <> arg3)
group |> inherit_from?({arg1, arg3}, {arg2, arg3})
end
end
end