cli: add buildtree checkout command#2129
Open
ownik wants to merge 1 commit into
Open
Conversation
948c3f3 to
cb60d5b
Compare
Author
|
@BenjaminSchubert @abderrahim @cs-shadow @gtristan @juergbi I've made changes to verify that buildtree exists in the cache, similar to the shell command. Could you please review, please? |
Contributor
|
Looks like this is fixing #1822, please link the issue in your PR. Also please add a test for this behaviour. I'll try to review it today. |
Contributor
|
A few things need to be considered in the design of this feature:
|
Add a new `bst buildtree checkout` command for exporting buildtree stored in artifacts. By default, the command checks out the buildtree. The `--buildroot` option can be used to export the entire buildroot sandbox instead. Fixed apache#1822
Author
|
@abderrahim Thanks for the feedback! I've reworked the implementation into a new I've also added an integration test covering the new command and link the issue in PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a "--use-buildtrees" option to "bst artifacts checkout", similar to the existing option in "bst shell".
The goal is to make it possible to check out build artifacts from the sandbox build tree when it is available.
Would be okay with adding this functionality, or are there reasons not to expose it through "bst artifacts checkout"? Or is there another way to get build artifacts from sandbox now?