Repository navigation
Bump httplib2 to 0.32.1 and remove distrusted eMudhra roots from Java cacerts - #40889
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40889 +/- ##
===========================================
+ Coverage 0 56.39% +56.39%
===========================================
Files 0 876 +876
Lines 0 154798 +154798
===========================================
+ Hits 0 87303 +87303
- Misses 0 65635 +65635
- Partials 0 1860 +1860
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
📋 Review Summary
This PR bumps httplib2 from 0.32.0 to 0.32.1 across all Python and ML container image requirements files and removes distrusted eMudhra / emSign root CA certificates from the OpenJDK cacerts truststores across the Java SDK, distroless Java SDK, expansion service, transform service, Flink job server, and Spark job server container images. The changes are clean, consistent, and ready to merge.
🔍 General Feedback
- The
keytoolpipeline handles both Java 8 (jre/lib/security/cacerts) and Java 11+ (lib/security/cacerts) paths insdks/java/container/Dockerfileand remains safe/idempotent if upstream base images remove these certificates in the future. - Copying the sanitized
cacertsinto/etc/ssl/certs/java/cacertsinsdks/java/container/distroless/Dockerfileproperly updates the truststore used by the distroless Java runtime.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Follow-up to #40696 and #40811:
httplib2from0.32.0to0.32.1across all Python and ML container image requirements files (0.32.1removes the distrusted eMudhra / emSign CA roots fromhttplib2/cacerts.txt).emsign/emudhraroot CA entries from the OpenJDKcacertstruststore in the Java SDK, distroless Java SDK, expansion service, transform service, Flink job server, and Spark job server container images.