Repository navigation
[KafkaIO] Use UnsignedLong for backlog calculation - #40840
Merged
Merged
Conversation
…in ReadFromKafkaDoFn
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
📋 Review Summary
This PR updates ReadFromKafkaDoFn to calculate estimated backlog bytes using Guava's UnsignedLong instead of BigDecimal, aligning it with the progress calculation in GrowableOffsetRangeTracker. It also updates outdated comments and log messages regarding offset estimator caching and lifecycle management (setup/teardown).
🔍 General Feedback
- The mathematical conversion using
UnsignedLong.fromLongBits(Math.max(expectedOffset, latestOffsetEstimator.get()) - expectedOffset)safely handles potential 64-bit signed integer overflow (since the minuend is guaranteed to be greater than or equal to the subtrahend) while avoidingBigDecimalallocation overhead on the hot path. - Comment and log message updates accurately reflect the current caching and DoFn lifecycle behavior.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Abacn
approved these changes
Oct 28, 2026
Abacn
left a comment
Abacn
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Nice optimization. Overflow case also covered by UnsignedLong.fromLongBits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a comment to align backlog calculation with changes made to growable offset trackers.