[jrmccluskey]

Modernize the ONNX extras group and re-enable testing, which has been disabled since 2024. Prior to updating, the onnx extras group was not able to install on any currently supported Python version.

[github-actions]

📋 Review Summary

This PR updates the onnx extra and ml_base_core dependency bounds in setup.py, re-enables the ONNX postcommit test tasks in tox.ini and build.gradle (testing lower-bound 119 and latest), and disables multi-process model sharing on OnnxModelHandlerNumPy since onnxruntime.InferenceSession manages its own native thread pools and cannot be safely proxied across processes.

🔍 General Feedback

• The changes to OnnxModelHandlerNumPy and the updated dependency/tox configurations are well-structured and clearly documented.
• Note that the branch currently has a merge conflict with recent master changes (from PR #40752) in .github/trigger_files/beam_PostCommit_Python_Dependency.json and adjacent lines in sdks/python/test-suites/tox/py311/build.gradle / sdks/python/tox.ini, so a rebase on master will be needed.
• One minor cleanup opportunity was noted in tox.ini regarding an obsolete onnx<1.19.0 pin in testenv:py311-ml.

---

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

[github-actions]

Assigning reviewers:

R: @tvalentyn for label python.
Backup reviewer: claudevdm (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.90%. Comparing base (2213e54) to head (b68dbda).
⚠️ Report is 47 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #40821       +/-   ##
===========================================
+ Coverage        0   79.90%   +79.90%     
===========================================
  Files           0      493      +493     
  Lines           0    83479    +83479     
===========================================
+ Hits            0    66706    +66706     
- Misses          0    16773    +16773     

Flag	Coverage Δ
python	79.90% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[tvalentyn]

do you think the upper bounds need to be so tight for this and the below? I'm trusting your judgement.

[jrmccluskey]

They do, unfortunately. There's some juggling between compatible versions of tensorflow and versions of torch that can exist in the same environment, which is not ideal but does keep the extra here working out-out-the-box.

[Amar3tto]

Should we cherrypick this into release-2.78 branch?

[jrmccluskey]

@Amar3tto Yeah I can open a cherrypick, this isn't a release blocker necessarily but ONNX was not going to work on 2.78.0 otherwise.