Repository navigation
[Experimental] Update google-adk dependency range - #40689
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40689 +/- ##
=============================================
+ Coverage 56.16% 80.02% +23.85%
=============================================
Files 1124 490 -634
Lines 178336 82818 -95518
Branches 1489 0 -1489
=============================================
- Hits 100170 66276 -33894
+ Misses 75645 16542 -59103
+ Partials 2521 0 -2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
📋 Review Summary
This PR updates ml_adk_dependency in sdks/python/setup.py to relax exact version pins into version ranges (google-adk>=2.0.0,<3 and opentelemetry-*>=1.36.0,<1.43) and bumps the beam_PreCommit_Python_ML trigger file. The changes are clean, properly scoped, and help unblock downstream ML dependency updates across Python versions.
🔍 General Feedback
- Replacing exact
==pins with bounded ranges inml_adk_dependencyaligns well with Beam's dependency management conventions insetup.py.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
|
||
| ml_adk_dependency = [ | ||
| 'google-adk==1.28.1', | ||
| 'google-adk>=2.0.0,<3', |
There was a problem hiding this comment.
Should we keep 1.28.1 as a lower bound?
There was a problem hiding this comment.
I think even if we kept the lower bound at 1.28.1 the dependency resolution process is always going to select for 2.0.0+ anyway, probably best to keep the bounds tighter given that would be the range getting pulled for testing.
There was a problem hiding this comment.
Oh fair - I was thinking that we exposed this as a non-test extra, but we don't. This seems fine then.
|
Thanks! |
Bump the google-adk range to major version 2, add ranges for relevant dependencies. This should unblock some other ML dependency updates for various Python versions downstream. An example of the downstream changes is available at #40531