Skip to content

[Experimental] Update google-adk dependency range - #40689

Merged
jrmccluskey merged 1 commit into
apache:masterfrom
jrmccluskey:actualADKJump
Oct 20, 2026
Merged

jrmccluskey merged 1 commit into
apache:masterfrom
jrmccluskey:actualADKJump

Conversation

@jrmccluskey

@jrmccluskey jrmccluskey commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Bump the google-adk range to major version 2, add ranges for relevant dependencies. This should unblock some other ML dependency updates for various Python versions downstream. An example of the downstream changes is available at #40531

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.02%. Comparing base (76f6e6d) to head (2faa8c6).
⚠️ Report is 250 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #40689       +/-   ##
=============================================
+ Coverage     56.16%   80.02%   +23.85%     
=============================================
  Files          1124      490      -634     
  Lines        178336    82818    -95518     
  Branches       1489        0     -1489     
=============================================
- Hits         100170    66276    -33894     
+ Misses        75645    16542    -59103     
+ Partials       2521        0     -2521     
Flag Coverage Δ
go ?
java ?
python 80.02% <ø> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jrmccluskey
jrmccluskey marked this pull request as ready for review October 20, 2026 17:17

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR updates ml_adk_dependency in sdks/python/setup.py to relax exact version pins into version ranges (google-adk>=2.0.0,<3 and opentelemetry-*>=1.36.0,<1.43) and bumps the beam_PreCommit_Python_ML trigger file. The changes are clean, properly scoped, and help unblock downstream ML dependency updates across Python versions.

🔍 General Feedback

  • Replacing exact == pins with bounded ranges in ml_adk_dependency aligns well with Beam's dependency management conventions in setup.py.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm for label python.
Backup reviewer: tvalentyn (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Comment thread sdks/python/setup.py

ml_adk_dependency = [
'google-adk==1.28.1',
'google-adk>=2.0.0,<3',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep 1.28.1 as a lower bound?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think even if we kept the lower bound at 1.28.1 the dependency resolution process is always going to select for 2.0.0+ anyway, probably best to keep the bounds tighter given that would be the range getting pulled for testing.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh fair - I was thinking that we exposed this as a non-test extra, but we don't. This seems fine then.

@damccorm

Copy link
Copy Markdown
Contributor

Thanks!

@jrmccluskey
jrmccluskey merged commit 14be1c0 into apache:master Oct 20, 2026
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants