[Amar3tto]

FIxes #38899
Successful run:
https://github.com/apache/beam/actions/runs/39422473838

[github-actions]

📋 Review Summary

This PR resolves compiler/ErrorProne errors in the Release Nightly Snapshot workflow by removing the deprecated finalize() method from JmsIO.UnboundedJmsReader (which implements Closeable via UnboundedReader and is managed by the runner) and adding @SuppressWarnings("PatternMatchingInstanceof") to DeltaWriteTestUtils and AddFilesIT to maintain Java 8 compatibility.

🔍 General Feedback

• The changes are minimal, targeted, and cleanly address the JDK 17+ / ErrorProne build failures while preserving Java 8 source compatibility.

---

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

[damccorm]

@Abacn could you take a look at this piece?

@Amar3tto could you add context on this piece?

[Amar3tto]

The finalize() method is deprecated and marked for removal in newer Java versions. Since UnboundedJmsReader already implements close() to release JMS resources, the finalizer is redundant. Resource cleanup should be handled explicitly through the reader lifecycle rather than relying on GC, which does not guarantee finalizer execution.

[github-actions]

Assigning reviewers:

R: @ahmedabu98 for label iceberg.
Backup reviewer: chamikaramj (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[Abacn]

Since there are multiple occurrence, we should add PatternMatchingInstanceOf into the global errorprome exclusion list, in BeamModulePlugin