Skip to content

Restore Java 11 support in setJavaVerOptions #40634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunping merged 2 commits into from
Oct 16, 2026
Merged

Restore Java 11 support in setJavaVerOptions #40634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3b2bbf
Restore Java 11 support in setJavaVerOptions
shunping Oct 16, 2026
964c13e
Trigger test workflow
shunping Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/trigger_files/beam_PreCommit_Java_IOs_Direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run.",
"modification": 1
}
4 changes: 3 additions & 1 deletion buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1021,7 +1021,9 @@ class BeamModulePlugin implements Plugin<Project> {
}
options.fork = true
options.forkOptions.javaHome = javaVerHome as File
if (ver == '17') {
if (ver == '11') {
// No additional options needed. Error Prone module exports are only required on JDK 16+.
} else if (ver == '17') {
options.forkOptions.jvmArgs += errorProneAddModuleOpts.collect { '-J' + it }
} else if (ver == '21' || ver == '25') {
options.compilerArgs += ['-Xlint:-this-escape']
Expand Down
Loading