Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40615 +/- ##
=============================================
+ Coverage 56.16% 79.88% +23.71%
=============================================
Files 1124 488 -636
Lines 178336 82431 -95905
Branches 1489 0 -1489
=============================================
- Hits 100170 65846 -34324
+ Misses 75645 16585 -59060
+ Partials 2521 0 -2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/gemini review |
There was a problem hiding this comment.
📋 Review Summary
This PR moves the remaining two YAML example files (bigquery_to_bigtable.yaml and gcs_avro_to_cloud_bigtable.yaml) from sdks/python/apache_beam/yaml/examples/transforms/blueprint/ to sdks/python/apache_beam/yaml/examples/transforms/pipelines/, completing the directory rename initiated in PR #40545. The change is clean and also restores test discovery for both examples under PipelinesTest in sdks/python/apache_beam/yaml/examples/testing/examples_test.py.
🔍 General Feedback
- No remaining files or references to
transforms/blueprintexist in the repository. - Both
test_bigquery_to_bigtable_yamlandtest_gcs_avro_to_cloud_bigtable_yamlare already registered inexamples_test.pypreprocessors and will now be properly discovered and executed byPipelinesTest.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
|
Assigning reviewers: R: @chamikaramj for label yaml. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Uh oh!
There was an error while loading. Please reload this page.