Repository navigation
Clarify known restrictions for model updates via side inputs. - #40600
Conversation
There was a problem hiding this comment.
📋 Review Summary
This PR updates the docstring for WatchFilePattern in apache_beam.ml.inference.utils to document known restrictions around file modification timestamps and uploading multiple model updates within a single polling interval.
🔍 General Feedback
- The documentation additions accurately reflect the behavior of
_GetLatestFileByTimeStamp,_ConvertIterToSingleton, and the downstreamAsSingletonside-input consumption pattern. - Formatting and numbering of the notes section are clean and consistent.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40600 +/- ##
=============================================
+ Coverage 56.16% 79.91% +23.74%
=============================================
Files 1124 488 -636
Lines 178336 82384 -95952
Branches 1489 0 -1489
=============================================
- Hits 100170 65834 -34336
+ Misses 75645 16550 -59095
+ Partials 2521 0 -2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
left a comment
There was a problem hiding this comment.
Thanks - this does seem like it could be fixable by looking at the timestamps and picking the latest, but this is fine for now
|
Yes, might be possible, we even have logic for that but it is broken: #40638 |
No description provided.