Skip to content

Clarify known restrictions for model updates via side inputs. - #40600

Merged
tvalentyn merged 1 commit into
apache:masterfrom
tvalentyn:side_input_model_update
Oct 16, 2026
Merged

tvalentyn merged 1 commit into
apache:masterfrom
tvalentyn:side_input_model_update

Conversation

@tvalentyn

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR updates the docstring for WatchFilePattern in apache_beam.ml.inference.utils to document known restrictions around file modification timestamps and uploading multiple model updates within a single polling interval.

🔍 General Feedback

  • The documentation additions accurately reflect the behavior of _GetLatestFileByTimeStamp, _ConvertIterToSingleton, and the downstream AsSingleton side-input consumption pattern.
  • Formatting and numbering of the notes section are clean and consistent.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@tvalentyn tvalentyn changed the title Clarify known restriction for model updates via side inputs. Clarify known restrictions for model updates via side inputs. Oct 15, 2026
@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.91%. Comparing base (76f6e6d) to head (7206237).
⚠️ Report is 212 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #40600       +/-   ##
=============================================
+ Coverage     56.16%   79.91%   +23.74%     
=============================================
  Files          1124      488      -636     
  Lines        178336    82384    -95952     
  Branches       1489        0     -1489     
=============================================
- Hits         100170    65834    -34336     
+ Misses        75645    16550    -59095     
+ Partials       2521        0     -2521     
Flag Coverage Δ
go ?
java ?
python 79.91% <ø> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm for label python.
Backup reviewer: shunping (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - this does seem like it could be fixable by looking at the timestamps and picking the latest, but this is fine for now

@tvalentyn

Copy link
Copy Markdown
Contributor Author

Yes, might be possible, we even have logic for that but it is broken: #40638

@tvalentyn
tvalentyn marked this pull request as ready for review October 16, 2026 19:16
@tvalentyn
tvalentyn merged commit a17e73a into apache:master Oct 16, 2026
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants