Repository navigation
Conversation
…resence of duplicates.
|
R: @bvolpato |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
assign set of reviewers |
|
Assigning reviewers: R: @jrmccluskey for label python. This pull request likely touches a core component ("core" label). Please review with scrutiny. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Test case is failing:
apache_beam.testing.util.BeamAssertException: Failed assert: ['/Users/runner/work/beam/beam/sdks/python/target/.tox/py311-macos/tmp/tmpd28ix9tp/tmpr3dn2ae0', '/Users/runner/work/beam/beam/sdks/python/target/.tox/py311-macos/tmp/tmpd28ix9tp/tmpr3dn2ae0'] == [FileMetadata(/Users/runner/work/beam/beam/sdks/python/target/.tox/py311-macos/tmp/tmpd28ix9tp/tmpr3dn2ae0, 0, 1792019102.680488), FileMetadata(/Users/runner/work/beam/beam/sdks/python/target/.tox/py311-macos/tmp/tmpd28ix9tp/tmpr3dn2ae0, 0, 1792019102.680488)], unexpected elements [FileMetadata(/Users/runner/work/beam/beam/sdks/python/target/.tox/py311-macos/tmp/tmpd28ix9tp/tmpr3dn2ae0, 0, 1792019102.680488), FileMetadata(/Users/runner/work/beam/beam/sdks/python/target/.tox/py311-macos/tmp/tmpd28ix9tp/tmpr3dn2ae0, 0, 1792019102.680488)], missing elements ['/Users/runner/work/beam/beam/sdks/python/target/.tox/py311-macos/tmp/tmpd28ix9tp/tmpr3dn2ae0', '/Users/runner/work/beam/beam/sdks/python/target/.tox/py311-macos/tmp/tmpd28ix9tp/tmpr3dn2ae0'] [while running 'assert_that/Match']
|
oops, yes, I assumed it was preexisting |
|
_create_extra_file did a bit more than what was written in its name |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40596 +/- ##
=============================================
+ Coverage 56.16% 79.94% +23.77%
=============================================
Files 1124 488 -636
Lines 178336 82556 -95780
Branches 1489 0 -1489
=============================================
- Hits 100170 65997 -34173
+ Misses 75645 16559 -59086
+ Partials 2521 0 -2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fix a flake that happened in #40000