Repository navigation
Bump minimum cryptography bounds beyond known severe CVEs - #40591
jrmccluskey wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
📋 Review Summary
This PR bumps the minimum required cryptography version in sdks/python/setup.py (install_requires) from >=39.0.0 to >=50.0.0 to prevent downstream users from resolving to versions affected by known severe CVEs. Version 50.0.0 is already pinned across all Python SDK container base image requirement files.
🔍 General Feedback
- Now that
install_requiresmandatescryptography>=50.0.0, the'cryptography>=41.0.2'entry inextras_require['test'](line 490 ofsdks/python/setup.py) is redundant and could be cleaned up or aligned in a follow-up.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40591 +/- ##
=============================================
+ Coverage 56.16% 79.93% +23.76%
=============================================
Files 1124 488 -636
Lines 178336 82349 -95987
Branches 1489 0 -1489
=============================================
- Hits 100170 65825 -34345
+ Misses 75645 16524 -59121
+ Partials 2521 0 -2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Assigning reviewers: R: @claudevdm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Just a minimum dependency bump to prevent downstream consumers and users from utilizing old versions, version 50.0.0 is already the version installed in Beam containers.