Skip to content

Bump minimum cryptography bounds beyond known severe CVEs - #40591

Open
jrmccluskey wants to merge 1 commit into
apache:masterfrom
jrmccluskey:cryptoScam
Open

jrmccluskey wants to merge 1 commit into
apache:masterfrom
jrmccluskey:cryptoScam

Conversation

@jrmccluskey

Copy link
Copy Markdown
Contributor

Just a minimum dependency bump to prevent downstream consumers and users from utilizing old versions, version 50.0.0 is already the version installed in Beam containers.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR bumps the minimum required cryptography version in sdks/python/setup.py (install_requires) from >=39.0.0 to >=50.0.0 to prevent downstream users from resolving to versions affected by known severe CVEs. Version 50.0.0 is already pinned across all Python SDK container base image requirement files.

🔍 General Feedback

  • Now that install_requires mandates cryptography>=50.0.0, the 'cryptography>=41.0.2' entry in extras_require['test'] (line 490 of sdks/python/setup.py) is redundant and could be cleaned up or aligned in a follow-up.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@codecov

codecov Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.93%. Comparing base (76f6e6d) to head (08176f8).
⚠️ Report is 171 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #40591       +/-   ##
=============================================
+ Coverage     56.16%   79.93%   +23.76%     
=============================================
  Files          1124      488      -636     
  Lines        178336    82349    -95987     
  Branches       1489        0     -1489     
=============================================
- Hits         100170    65825    -34345     
+ Misses        75645    16524    -59121     
+ Partials       2521        0     -2521     
Flag Coverage Δ
go ?
java ?
python 79.93% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @claudevdm for label python.
Backup reviewer: tvalentyn (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant