Repository navigation
update node in workflows to 24 - #40590
Conversation
|
/gemini review |
There was a problem hiding this comment.
📋 Review Summary
This pull request updates the Node.js version configured across several GitHub Actions workflows and .github/ACTIONS.md documentation from older versions (16, 18, and 20) to Node 24. The changes are clean, consistent, and align with actions/setup-node@v7 across the repository.
🔍 General Feedback
- All
actions/setup-nodesteps across.github/workflowsand.github/ACTIONS.mdare now consistently targeting Node 24. - Note that
typescript_tests.ymlonly triggers automatically on pull requests when files undersdks/typescript/**are modified; it may be worth triggering a manualworkflow_dispatchrun or verifying thatsdks/typescriptbuilds and passes tests cleanly under Node 24.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
|
Assigning reviewers: R: @Amar3tto for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
📋 Review Summary
This PR cleanly updates the actions/setup-node configuration across GitHub Actions workflows and documentation from Node.js 16/20 to Node.js 24 LTS. The changes are straightforward, consistent across the affected CI workflows, and have been verified to work with the TypeScript SDK test suite.
🔍 General Feedback
- All
actions/setup-nodeversion references across.github/workflows/and.github/ACTIONS.mdare consistently updated to Node 24. - Follow-up consideration (out of scope for this workflow-focused PR):
sdks/typescript/container/Dockerfilestill usesFROM node:18.18-bullseye-slimandscripts/ci/pr-bot/package.jsonstill pins@types/nodeto^16.11.7, which may be worth updating in a separate change to align runtime/type definitions with the CI environment.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
Problem: a few workflows try to still use Node 16,18,20.
Plan: bump to 24.