Skip to content

update node in workflows to 24 - #40590

Merged
derrickaw merged 1 commit into
apache:masterfrom
derrickaw:20261014_updateNodeVersions
Oct 15, 2026
Merged

derrickaw merged 1 commit into
apache:masterfrom
derrickaw:20261014_updateNodeVersions

Conversation

@derrickaw

Copy link
Copy Markdown
Collaborator

Problem: a few workflows try to still use Node 16,18,20.
Plan: bump to 24.

@derrickaw derrickaw changed the title update node to 24 update node in workflows to 24 Oct 14, 2026
@github-actions github-actions Bot added the build label Oct 14, 2026
@derrickaw

Copy link
Copy Markdown
Collaborator Author

/gemini review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This pull request updates the Node.js version configured across several GitHub Actions workflows and .github/ACTIONS.md documentation from older versions (16, 18, and 20) to Node 24. The changes are clean, consistent, and align with actions/setup-node@v7 across the repository.

🔍 General Feedback

  • All actions/setup-node steps across .github/workflows and .github/ACTIONS.md are now consistently targeting Node 24.
  • Note that typescript_tests.yml only triggers automatically on pull requests when files under sdks/typescript/** are modified; it may be worth triggering a manual workflow_dispatch run or verifying that sdks/typescript builds and passes tests cleanly under Node 24.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@derrickaw
derrickaw marked this pull request as ready for review October 14, 2026 19:03
@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @Amar3tto for label build.
Backup reviewer: Abacn (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR cleanly updates the actions/setup-node configuration across GitHub Actions workflows and documentation from Node.js 16/20 to Node.js 24 LTS. The changes are straightforward, consistent across the affected CI workflows, and have been verified to work with the TypeScript SDK test suite.

🔍 General Feedback

  • All actions/setup-node version references across .github/workflows/ and .github/ACTIONS.md are consistently updated to Node 24.
  • Follow-up consideration (out of scope for this workflow-focused PR): sdks/typescript/container/Dockerfile still uses FROM node:18.18-bullseye-slim and scripts/ci/pr-bot/package.json still pins @types/node to ^16.11.7, which may be worth updating in a separate change to align runtime/type definitions with the CI environment.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@derrickaw
derrickaw merged commit cddfa4b into apache:master Oct 15, 2026
11 checks passed
@derrickaw
derrickaw deleted the 20261014_updateNodeVersions branch October 15, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants