Skip to content

poll BigQuery matchers on missing tables - #40559

Merged
Abacn merged 4 commits into
apache:masterfrom
aIbrahiim:fix-bq-matcher-404-poll
Oct 15, 2026
Merged

Abacn merged 4 commits into
apache:masterfrom
aIbrahiim:fix-bq-matcher-404-poll

Conversation

@aIbrahiim

@aIbrahiim aIbrahiim commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Fixes: #30760
PostCommit Python Arm streaming tests were failing because the BigQuery table does not exist until the first insert and the matcher already had a timeout, but a 404 stopped the query after a few retries, so that wait never ran

This keeps polling while the table is missing, until the timeout that was already configured. A 404 with no timeout still fails immediately and I checked the matcher unit tests locally

@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.90%. Comparing base (76f6e6d) to head (5498fdb).
⚠️ Report is 178 commits behind head on master.

Files with missing lines Patch % Lines
...ython/apache_beam/io/gcp/tests/bigquery_matcher.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #40559       +/-   ##
=============================================
+ Coverage     56.16%   79.90%   +23.74%     
=============================================
  Files          1124      488      -636     
  Lines        178336    82397    -95939     
  Branches       1489        0     -1489     
=============================================
- Hits         100170    65843    -34327     
+ Misses        75645    16554    -59091     
+ Partials       2521        0     -2521     
Flag Coverage Δ
go ?
java ?
python 79.90% <93.75%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aIbrahiim
aIbrahiim marked this pull request as ready for review October 13, 2026 20:37
@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @claudevdm for label python.
Backup reviewer: jrmccluskey (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions github-actions Bot added the build label Oct 13, 2026
@Amar3tto
Amar3tto requested a review from Abacn October 14, 2026 13:02
@Abacn

Abacn commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Thanks for root causing it. There is no change on bigquery_matcher.py recently, is it caused by a offending Beam PR? If not, what time this breakage started happen (which then suggest a BigQuery service breaking change)

@aIbrahiim

Copy link
Copy Markdown
Contributor Author

Thanks for root causing it. There is no change on bigquery_matcher.py recently, is it caused by a offending Beam PR? If not, what time this breakage started happen (which then suggest a BigQuery service breaking change)

No, bigquery_matcher.py did not change recently and the last edit before this was formatting only

It also did not start at one specific time and the same test still passes on some runs and fails on others, so it does not look like a BigQuery breaking change

Comment thread sdks/python/apache_beam/io/gcp/tests/bigquery_matcher.py Outdated

@Abacn Abacn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Abacn
Abacn merged commit 5f41ff4 into apache:master Oct 15, 2026
92 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit Python Arm job is flaky

2 participants