Skip to content

Replace typing.ByteString with collections.abc.Buffer - #40554

Merged
jrmccluskey merged 7 commits into
apache:masterfrom
jrmccluskey:typehintsBuffer
Oct 15, 2026
Merged

jrmccluskey merged 7 commits into
apache:masterfrom
jrmccluskey:typehintsBuffer

Conversation

@jrmccluskey

Copy link
Copy Markdown
Contributor

Bring row_type.py and schemas.py in line with both PEP 585 and PEP 688 (deprecation of typing.ByteString in favor of collections.abc.Buffer) while keeping a typing_extensions variant in place for Python 3.11.

@github-actions github-actions Bot added the io label Oct 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm for label python.
Backup reviewer: shunping (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

This pull request likely touches a core component ("core" label). Please review with scrutiny.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions github-actions Bot added the gcp label Oct 13, 2026
@codecov

codecov Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.94%. Comparing base (76f6e6d) to head (7c38b87).
⚠️ Report is 162 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #40554       +/-   ##
=============================================
+ Coverage     56.16%   79.94%   +23.77%     
=============================================
  Files          1124      488      -636     
  Lines        178336    82345    -95991     
  Branches       1489        0     -1489     
=============================================
- Hits         100170    65830    -34340     
+ Misses        75645    16515    -59130     
+ Partials       2521        0     -2521     
Flag Coverage Δ
go ?
java ?
python 79.94% <100.00%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@damccorm damccorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jrmccluskey
jrmccluskey merged commit 8c100dd into apache:master Oct 15, 2026
107 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants