Repository navigation
[OpenTelemetry] Spanner change streams otel configuration cleanup - #40552
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
00ecd70 to
f333f5b
Compare
|
Assigning reviewers: R: @nielm for label spanner. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
assign to next reviewer |
|
nielm is on pto |
| /** | ||
| * Specifies whether OpenTelemetry tracing should start trace and span on each change record. | ||
| * For Spanner Client library tracing config, use SpannerConfig (withSpannerConfig). | ||
| */ | ||
| public ReadChangeStream withEnableOpenTelemetryTracing(boolean enableOpenTelemetryTracing) { |
There was a problem hiding this comment.
I think withOpenTelemetryTracing() would read better as builder
withDatabaseId(blah).withOpenTelemetryTracing()
But also maybe this should be a little clearer on the tracing it enables,
withPerChangeRecordOpenTelementryTracing()
| /** Specifies whether OpenTelemetry tracing is enabled. */ | ||
| /** | ||
| * Specifies whether OpenTelemetry tracing should start trace and span on each change record. | ||
| * For Spanner Client library tracing config, use SpannerConfig (withSpannerConfig). |
There was a problem hiding this comment.
how about
Spanner Client library tracing can be enabled via the SpannerConfig passed to withSpannerConfig.
2 participants
SpannerIO has both per element open telemetry tracing and allows to configure Spanner Client to also add additional traces.
This change cleans up configuration so those two can be configured separately.