Repository navigation
[Python] Fix DataFrame Series.value_counts with bins - #40505
Open
anishmehta24 wants to merge 1 commit into
Open
anishmehta24 wants to merge 1 commit into
anishmehta24 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40505 +/- ##
=============================================
+ Coverage 56.16% 79.72% +23.55%
=============================================
Files 1124 487 -637
Lines 178336 82289 -96047
Branches 1489 0 -1489
=============================================
- Hits 100170 65603 -34567
+ Misses 75645 16686 -58959
+ Partials 2521 0 -2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
shunping
requested changes
Oct 12, 2026
shunping
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Could you rebase to the master and resolve the conflict? Thanks!
Contributor
Author
|
Rebased on master and kept both CHANGES.md entries. Thanks! |
anishmehta24
force-pushed
the
fix/value-counts-bins
branch
from
October 12, 2026 22:15
8d6ee0d to
d59b30a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40503
[self._expr]was inside the lambda in thebinsbranch ofvalue_counts, soComputedExpressionwas created without its args and always raised aTypeError. This moves it out, and builds the proxy from a one-element Series since pandas can't compute bins for the empty proxy. Added a test to frames_test.py and a CHANGES.md entry.Written with help from Claude.