Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -360,8 +360,12 @@ private void handleOnlyFinalize(
Windmill.WorkItemCommitRequest.Builder outputBuilder =
initializeOutputBuilder(workItem.getKey(), workItem);
outputBuilder.setSourceStateUpdates(Windmill.SourceState.newBuilder().setOnlyFinalize(true));
work.setState(Work.State.COMMIT_QUEUED);
work.queueCommit(outputBuilder.build(), computationState);
commitWorkBatch(
computationState,
ImmutableList.of(work),
ImmutableList.of(outputBuilder.build()),
ImmutableList.of(),
ImmutableList.of());
}

private StageInfo getStageInfo(ComputationState computationState) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3638,7 +3638,111 @@ public void testUnboundedSourcesDrain() throws Exception {
commit = result.get(3L);

assertThat(
commit,
removeDynamicFields(commit),
equalTo(
parseCommitRequest(
"key: \"0000000000000001\" "
+ "sharding_key: 1 "
+ "work_token: 3 "
+ "cache_token: 3 "
+ "source_state_updates {"
+ " only_finalize: true"
+ "} ")
.build()));

assertThat(finalizeTracker, contains(0));
worker.stop();
}

@Test
public void testUnboundedSourcesDrain_multiKeyBundleEnabled() throws Exception {
if (!streamingEngine) {
return;
}
List<Integer> finalizeTracker = Lists.newArrayList();
TestCountingSource.setFinalizeTracker(finalizeTracker);
server.clearCommitsReceived();

StreamingDataflowWorker worker =
makeWorker(
defaultWorkerParams("--experiments=unstable_enable_multi_key_bundle")
.setInstructions(makeUnboundedSourcePipeline())
.publishCounters()
.build());
worker.start();

server
.whenGetWorkCalled()
.thenReturn(
buildInput(
"work {"
+ " computation_id: \"computation\""
+ " input_data_watermark: 0"
+ " work {"
+ " key: \"0000000000000001\""
+ " sharding_key: 1"
+ " work_token: 2"
+ " cache_token: 3"
+ " key_group { high: 0 low: 1 }"
+ " }"
+ "}",
null));

Map<Long, Windmill.WorkItemCommitRequest> result = server.waitForAndGetCommits(1);
Windmill.WorkItemCommitRequest commit = result.get(2L);
assertEquals(1, commit.getSourceStateUpdates().getFinalizeIdsCount());
UnsignedLong finalizeId =
UnsignedLong.fromLongBits(commit.getSourceStateUpdates().getFinalizeIds(0));

// Test drain work item with only_finalize.
server
.whenGetWorkCalled()
.thenReturn(
buildInput(
"work {"
+ " computation_id: \"computation\""
+ " input_data_watermark: 0"
+ " work {"
+ " key: \"0000000000000001\""
+ " sharding_key: 1"
+ " work_token: 3"
+ " cache_token: 3"
+ " key_group { high: 0 low: 1 }"
+ " source_state {"
+ " only_finalize: true"
+ " finalize_ids: "
+ finalizeId
+ " }"
+ " }"
+ "}",
null));

result = server.waitForAndGetCommits(1);
commit = result.get(3L);

assertThat(
removeDynamicFields(commit),
equalTo(
parseCommitRequest(
"key: \"0000000000000001\" "
+ "sharding_key: 1 "
+ "work_token: 3 "
+ "cache_token: 3 "
+ "source_state_updates {"
+ " only_finalize: true"
+ "} ")
.build()));

List<Windmill.MultiKeyWorkItemCommitRequest> multiKeyCommits =
server.getMultiKeyCommitsReceived();
assertEquals(2, multiKeyCommits.size());
Windmill.MultiKeyWorkItemCommitRequest finalizeMultiKeyCommit = multiKeyCommits.get(1);
assertEquals(
Windmill.Uint128Proto.newBuilder().setHigh(0).setLow(1).build(),
finalizeMultiKeyCommit.getKeyGroup());
assertEquals(1, finalizeMultiKeyCommit.getRequestsCount());
assertThat(
removeDynamicFields(finalizeMultiKeyCommit.getRequests(0)),
equalTo(
parseCommitRequest(
"key: \"0000000000000001\" "
Expand Down
Loading