Repository navigation
Conversation
|
R: @tvalentyn |
|
|
||
| def force_reset(self): | ||
| if self.use_model_manager: | ||
| self.models.force_reset() |
There was a problem hiding this comment.
should this call self.models._force_reset() ?
There was a problem hiding this comment.
Good catch! Yes it should be.
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #40473 +/- ##
============================================
+ Coverage 56.16% 56.25% +0.09%
Complexity 2288 2288
============================================
Files 1124 1124
Lines 178336 178392 +56
Branches 1489 1489
============================================
+ Hits 100170 100363 +193
+ Misses 75645 75508 -137
Partials 2521 2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
happy to merge once tests pass. |
| self._monitor.reset_peak() | ||
|
|
||
| def force_reset(self): | ||
| self._force_reset() |
There was a problem hiding this comment.
nit: we could remove _force_reset in this case, i think it is barely used.
There was a problem hiding this comment.
Yep sg! Let me adjust it.
Fixes Issue #40469