Repository navigation
[Python] Don't skip a delimiter right after an escaped one in ReadFromText - #40460
Merged
damccorm merged 2 commits intoOct 8, 2026
Merged
Conversation
ReadFromText with escapechar merged the next record into the current one.
Contributor
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40460 +/- ##
=============================================
+ Coverage 59.04% 79.55% +20.51%
=============================================
Files 2797 487 -2310
Lines 280750 82225 -198525
Branches 12488 0 -12488
=============================================
- Hits 165764 65413 -100351
+ Misses 108540 16812 -91728
+ Partials 6446 0 -6446
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
escapecharset,ReadFromTextskipped a delimiter that comes right after an escaped one, sob'a\\\n\nb\n'read as['a\\\n\nb']instead of['a\\\n', 'b'](same with custom delimiters)._find_separator_boundsresumed the search one byte past the escaped delimiter; it now resumes right after it. Added a test that fails on master; theTextSourceTesttests intextio_test.pypass.fixes #40459
Written with help from Claude.
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.