Skip to content

Prep changes for merging ValidatesRunner jobs - #40436

Merged
reuvenlax merged 1 commit into
apache:masterfrom
reuvenlax:merge_validates_runner_core
Oct 13, 2026
Merged

reuvenlax merged 1 commit into
apache:masterfrom
reuvenlax:merge_validates_runner_core

Conversation

@reuvenlax

Copy link
Copy Markdown
Contributor

In preparation for merging multiple ValidatesRunner tests into a single pipeline:

  • Add a CompositePipeline class that can hold multiple pipelines. This forwards visitors and translation to all subpipelines.
  • Changes to the Pipeline translation visitor to handle CompositePipeline.
  • CompositePipeline expects that all steps in all pipelines have distinct names. To enable this, TransformHierarchy.java now has setRootName, which allows for a distinct root name (only the root of a hierarchy needs a distinct name. Note this is done as a method instead of a constructor parameter since we need to use it in TestPipeline, and the test name is not known when the TestPipeline rule is constructed.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.74%. Comparing base (69bdf5f) to head (3140eb7).
⚠️ Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
...in/java/org/apache/beam/sdk/CompositePipeline.java 88.88% 3 Missing and 1 partial ⚠️
...rg/apache/beam/sdk/runners/TransformHierarchy.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #40436      +/-   ##
============================================
- Coverage     59.04%   58.74%   -0.30%     
+ Complexity    15624    13916    -1708     
============================================
  Files          2797     2584     -213     
  Lines        280750   271478    -9272     
  Branches      12488    11235    -1253     
============================================
- Hits         165764   159490    -6274     
+ Misses       108540   105993    -2547     
+ Partials       6446     5995     -451     
Flag Coverage Δ
java 65.25% <90.19%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @kennknowles for label java.

This pull request likely touches a core component ("core" label). Please review with scrutiny.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@reuvenlax

Copy link
Copy Markdown
Contributor Author

@kennknowles friendly ping

@reuvenlax
reuvenlax merged commit fb0a6a4 into apache:master Oct 13, 2026
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants