Repository navigation
[Python] Remove leftover "### Labels" debug log in the BigQuery source - #40430
Merged
jrmccluskey merged 1 commit intoOct 6, 2026
Merged
Conversation
_CustomBigQueryStorageSource._setup_temporary_dataset logged the dataset labels at warning level, right before passing them to create_temporary_dataset. The "###" prefix appears in no other logging call under sdks/python/apache_beam, and str() is redundant with %s, both of which point at a debug print rather than an intended log line. The labels come from the user, so the value carries no information the caller does not already have. The line dates back to apache#15602 and no test refers to it. _LOGGER is still used at nine call sites in the module.
Contributor
|
Assigning reviewers: R: @jrmccluskey for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40430 +/- ##
=========================================
Coverage 59.04% 59.04%
Complexity 15624 15624
=========================================
Files 2797 2797
Lines 280750 280787 +37
Branches 12488 12488
=========================================
+ Hits 165764 165796 +32
- Misses 108540 108545 +5
Partials 6446 6446
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_CustomBigQueryStorageSource._setup_temporary_datasetlogs the dataset labels at warning level, right before passing the same value tocreate_temporary_dataset:beam/sdks/python/apache_beam/io/gcp/bigquery.py
Line 1152 in c74609d
Three things suggest a debug print rather than an intended log line :
###appears in no other logging call undersdks/python/apache_beam, across its 1380.pyfilesstr()is redundant with%s_LOGGER.warning(...)call in the module, and it reports a value the caller supplied in the first placegit blameputs the line in #15602, which added the BigQuery Read API support in October 2021, and it has not changed sinceNo test refers to it : the only
assertLogsinio/gcpisbigquery_test.py:398, which targets a DEBUG message frombigquery_read_internalon an unrelated path_LOGGERis still used at nine call sites in the module, so nothing becomes unusedChecked with
yapf==0.43.0, the version pinned intox.ini:294: no diffIf you would rather keep the value visible, I am happy to demote it to
debuginstead of removing itaddresses #123), if applicable.CHANGES.mdwith noteworthy changes.