Skip to content

pass the runner clock into batch triggers - #40429

Closed
aIbrahiim wants to merge 1 commit into
apache:masterfrom
aIbrahiim:fix-fnapi-trigger-clock
Closed

aIbrahiim wants to merge 1 commit into
apache:masterfrom
aIbrahiim:fix-fnapi-trigger-clock

Conversation

@aIbrahiim

Copy link
Copy Markdown
Contributor
  • FnApi batch triggers had no clock, so a processing-time trigger crashed or fired immediately
  • Pass the runner clock through and leave future processing-time timers queued
  • Split out of fix leader board trigger #40370 so the leader board example can be reviewed on its own

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README for a list of workflows and how to trigger them.

@codecov

codecov Bot commented Oct 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.20%. Comparing base (78c9e10) to head (5e79a0b).
⚠️ Report is 59 commits behind head on master.

Files with missing lines Patch % Lines
sdks/python/apache_beam/transforms/trigger.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #40429      +/-   ##
============================================
+ Coverage     56.15%   56.20%   +0.05%     
  Complexity     2288     2288              
============================================
  Files          1121     1123       +2     
  Lines        177193   178214    +1021     
  Branches       1489     1489              
============================================
+ Hits          99504   100168     +664     
- Misses        75168    75525     +357     
  Partials       2521     2521              
Flag Coverage Δ
python 79.67% <72.72%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @claudevdm for label python.

This pull request likely touches a core component ("core" label). Please review with scrutiny.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant