Repository navigation
Conversation
731e755 to
2221917
Compare
|
Assigning reviewers: R: @lostluck for label go. This pull request likely touches a core component ("core" label). Please review with scrutiny. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
left a comment
There was a problem hiding this comment.
Thanks! Could you please resolve the merge conflicts? If so, I can merge
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #40406 +/- ##
============================================
+ Coverage 56.16% 57.63% +1.46%
Complexity 2288 2288
============================================
Files 1124 1125 +1
Lines 178336 167497 -10839
Branches 1489 1489
============================================
- Hits 100170 96539 -3631
+ Misses 75645 68419 -7226
- Partials 2521 2539 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks @damccorm. Fixed |
fixes #40405
Add "errors.Wrapf" for the last send error in dataWriter.Close and timerWriter.Close()