Skip to content

[Go SDK] wrap a failed last data/timer send like Flush - #40406

Open
igor-dv wants to merge 3 commits into
apache:masterfrom
igor-dv:go-harness-last-send
Open

igor-dv wants to merge 3 commits into
apache:masterfrom
igor-dv:go-harness-last-send

Conversation

@igor-dv

@igor-dv igor-dv commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

fixes #40405

Add "errors.Wrapf" for the last send error in dataWriter.Close and timerWriter.Close()

@igor-dv
igor-dv force-pushed the go-harness-last-send branch from 731e755 to 2221917 Compare October 4, 2026 21:31
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @lostluck for label go.

This pull request likely touches a core component ("core" label). Please review with scrutiny.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please resolve the merge conflicts? If so, I can merge

@codecov

codecov Bot commented Oct 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.63%. Comparing base (76f6e6d) to head (4ac2e09).
⚠️ Report is 111 commits behind head on master.

Files with missing lines Patch % Lines
sdks/go/pkg/beam/core/runtime/harness/datamgr.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #40406      +/-   ##
============================================
+ Coverage     56.16%   57.63%   +1.46%     
  Complexity     2288     2288              
============================================
  Files          1124     1125       +1     
  Lines        178336   167497   -10839     
  Branches       1489     1489              
============================================
- Hits         100170    96539    -3631     
+ Misses        75645    68419    -7226     
- Partials       2521     2539      +18     
Flag Coverage Δ
go 28.46% <66.66%> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@igor-dv

igor-dv commented Oct 11, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @damccorm. Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Go harness last dataWriter/timerWriter send errors are not wrapped

2 participants