Repository navigation
Conversation
|
Assigning reviewers: R: @ahmedabu98 for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Hi @derrickaw, I hit the same |
Hi @tkaymak, I think yours is better. Will defer to yours. Thanks! |
testBufferStopsAcceptingItems asserted the buffer count after a fixed 100ms sleep, which failed on slow Windows runners (expected 5 but was 0). Add an optional CountDownLatch gate to BasicDofn so tests hold elements in-flight until they release it, instead of relying on wall-clock sleeps. testBufferStopsAcceptingItems now joins all producers before asserting that exactly 5 items are buffered, then verifies the 5 throttled items are rescheduled and emitted. testBufferCount, testBufferWithCancellation and testLongItem use the same gate; testSlowDuplicates waits for the buffer to drain instead of sleeping. Fixes #40448. Supersedes the timing-based approach in #40397.
Seeing this failure:
Gradle Test Run :sdks:java:core:test > Gradle Test Executor 2 > AsyncWrapperTest > testBufferStopsAcceptingItems FAILED
java.lang.AssertionError: expected:<5> but was:<0>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:633)
at org.apache.beam.sdk.transforms.AsyncWrapperTest.testBufferStopsAcceptingItems(AsyncWrapperTest.java:678)
here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README for a list of workflows and how to trigger them.