Skip to content

[Claude] Capture behavior of the BigQueryWrapper during requests - #40357

Draft
jrmccluskey wants to merge 2 commits into
apache:masterfrom
jrmccluskey:bqPhase0Characterization
Draft

jrmccluskey wants to merge 2 commits into
apache:masterfrom
jrmccluskey:bqPhase0Characterization

Conversation

@jrmccluskey

@jrmccluskey jrmccluskey commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Implements a framework for capturing the existing behavior of requests sent over the wire via the BigQueryWrapper through the generated apitools client + captures the current behavior of those requests in the success, error, and retry paths. Does not change any prod behavior beyond packaging the golden jsons in Beam for testing purposes. These files are largely meant to be temporary to ensure migration to the modern BQ client does not cause any regressions.

Part of #37261


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@jrmccluskey
jrmccluskey force-pushed the bqPhase0Characterization branch from 7092df9 to a34dfc4 Compare October 12, 2026 16:15
@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.46847% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.92%. Comparing base (76f6e6d) to head (5fdcaa2).
⚠️ Report is 137 commits behind head on master.

Files with missing lines Patch % Lines
...apache_beam/io/gcp/tests/bigquery_http_recorder.py 93.46% 29 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #40357       +/-   ##
=============================================
+ Coverage     56.16%   79.92%   +23.75%     
=============================================
  Files          1124      488      -636     
  Lines        178336    82713    -95623     
  Branches       1489        0     -1489     
=============================================
- Hits         100170    66109    -34061     
+ Misses        75645    16604    -59041     
+ Partials       2521        0     -2521     
Flag Coverage Δ
go ?
java ?
python 79.92% <93.46%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @shunping for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant