Skip to content

add pubsub max_read_time_seconds parameter - #40341

Draft
derrickaw wants to merge 2 commits into
apache:masterfrom
derrickaw:20260929_addMaxReadTimePubsub
Draft

derrickaw wants to merge 2 commits into
apache:masterfrom
derrickaw:20260929_addMaxReadTimePubsub

Conversation

@derrickaw

@derrickaw derrickaw commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Problem: ReadFromKafka has max_read_time_seconds parameter preventing the pipeline from reading forever if so desired by the user. ReadFromPubSub transform doesn't have this feature.

Goals: add max_read_time_seconds parameter to ReadFromPubSub transform, add testing, and also cover publish_time parameter in yaml test based on previous PR merge. Fixes #39009


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov

codecov Bot commented Oct 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.57055% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.23%. Comparing base (22a237b) to head (d990a93).
⚠️ Report is 194 commits behind head on master.

Files with missing lines Patch % Lines
sdks/python/apache_beam/io/gcp/pubsub.py 87.93% 14 Missing ⚠️
.../apache_beam/runners/direct/transform_evaluator.py 91.89% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #40341      +/-   ##
============================================
- Coverage     57.25%   56.23%   -1.02%     
+ Complexity     3695     2290    -1405     
============================================
  Files          1200     1123      -77     
  Lines        194194   178302   -15892     
  Branches       3889     1486    -2403     
============================================
- Hits         111183   100273   -10910     
+ Misses        79406    75508    -3898     
+ Partials       3605     2521    -1084     
Flag Coverage Δ
python 79.69% <89.57%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add max_read_time to ReadFromPubsub similar to ReadFromKafka

1 participant