Skip to content

[Gemini] Add ExpireSnapshots maintenance operation to Iceberg IO - #40094

Draft
jrmccluskey wants to merge 2 commits into
apache:masterfrom
jrmccluskey:expireSnapshots
Draft

jrmccluskey wants to merge 2 commits into
apache:masterfrom
jrmccluskey:expireSnapshots

Conversation

@jrmccluskey

Copy link
Copy Markdown
Contributor

Implements classes and transforms for the ExpireSnapshots Iceberg table maintenance operation.

Fixes #39224


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions Bot added java io iceberg Iceberg IO connector labels Sep 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @chamikaramj for label java.
R: @ahmedabu98 for label iceberg.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions

Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @chamikaramj @ahmedabu98

@github-actions

Copy link
Copy Markdown
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @ahmedabu98 for label iceberg.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@kennknowles

Copy link
Copy Markdown
Member

R: @ahmedabu98

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @kennknowles @ahmedabu98

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.
R: @chamikaramj for label iceberg.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@kennknowles

Copy link
Copy Markdown
Member

Does the bot not cede control any more?

@jrmccluskey
jrmccluskey requested a review from ahmedabu98 October 6, 2026 15:54
@jrmccluskey

Copy link
Copy Markdown
Contributor Author

Not sure how the bot handles the R: tag syntax now, but it's better to just use github's built-in reviewer assignment instead if you're re-routing anyway

@github-actions

Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @Abacn @chamikaramj @ahmedabu98

@damccorm

Copy link
Copy Markdown
Contributor

Does the bot not cede control any more?

It should, this looks like a bug. It could have just been a transient GHA failure, so trying again. If that doesn't work I'll look into it

@damccorm

Copy link
Copy Markdown
Contributor

R: @ahmedabu98

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@jrmccluskey
jrmccluskey marked this pull request as draft October 15, 2026 17:32
@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.63%. Comparing base (84713ce) to head (178cfed).
⚠️ Report is 394 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #40094      +/-   ##
============================================
+ Coverage     57.24%   58.63%   +1.39%     
- Complexity     3696    13982   +10286     
============================================
  Files          1200     2590    +1390     
  Lines        194031   270798   +76767     
  Branches       3889    11306    +7417     
============================================
+ Hits         111070   158791   +47721     
- Misses        79366   105986   +26620     
- Partials       3595     6021    +2426     
Flag Coverage Δ
java 65.05% <ø> (-7.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add Expire Snapshots maintenance in Iceberg

3 participants