Fix dataframe CSV tests on Windows - #39563
Open
Guflly wants to merge 1 commit into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
|
Assigning reviewers: R: @jrmccluskey for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Guflly
force-pushed
the
fix/windows-dataframe-io-tests
branch
from
July 31, 2026 12:53
a8e56e6 to
00b4954
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #39563 +/- ##
=========================================
Coverage 58.16% 58.16%
Complexity 13086 13086
=========================================
Files 2521 2521
Lines 264569 264569
Branches 10788 10788
=========================================
+ Hits 153879 153882 +3
+ Misses 104923 104920 -3
Partials 5767 5767
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20642.
The dataframe CSV sink wrapped a binary stream with default newline translation, which turned pandas CRLF endings into extra blank lines on Windows. Windowed test filenames also used colon-containing timestamps.
This disables newline translation for text sinks and uses the existing Windows-safe naming pattern in the windowed test, allowing the full IO test class to run on Windows.
Tests:
python -m pytest -q apache_beam\dataframe\io_test.py(33 passed, 5 skipped)python -m yapf --diff apache_beam\dataframe\io.py apache_beam\dataframe\io_test.py