Skip to content

Fix dataframe CSV tests on Windows - #39563

Open
Guflly wants to merge 1 commit into
apache:masterfrom
Guflly:fix/windows-dataframe-io-tests
Open

Fix dataframe CSV tests on Windows#39563
Guflly wants to merge 1 commit into
apache:masterfrom
Guflly:fix/windows-dataframe-io-tests

Conversation

@Guflly

@Guflly Guflly commented Jul 31, 2026

Copy link
Copy Markdown

Fixes #20642.

The dataframe CSV sink wrapped a binary stream with default newline translation, which turned pandas CRLF endings into extra blank lines on Windows. Windowed test filenames also used colon-containing timestamps.

This disables newline translation for text sinks and uses the existing Windows-safe naming pattern in the windowed test, allowing the full IO test class to run on Windows.

Tests:

  • python -m pytest -q apache_beam\dataframe\io_test.py (33 passed, 5 skipped)
  • python -m yapf --diff apache_beam\dataframe\io.py apache_beam\dataframe\io_test.py

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @jrmccluskey for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Guflly
Guflly force-pushed the fix/windows-dataframe-io-tests branch from a8e56e6 to 00b4954 Compare July 31, 2026 12:53
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.16%. Comparing base (9c561e2) to head (00b4954).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #39563   +/-   ##
=========================================
  Coverage     58.16%   58.16%           
  Complexity    13086    13086           
=========================================
  Files          2521     2521           
  Lines        264569   264569           
  Branches      10788    10788           
=========================================
+ Hits         153879   153882    +3     
+ Misses       104923   104920    -3     
  Partials       5767     5767           
Flag Coverage Δ
python 79.83% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix csv reading tests on Windows

1 participant