You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Bug]: Typo __int__ in MilvusBaseRanker and wrong type hint on milvus_search.join_fn #40474
"""Base class for ranking algorithms in Milvus hybrid search strategy."""
def__int__(self):
return
classMilvusBaseRanker:
def__int__(self):
return
This looks like a typo for __init__. As written, it defines the integer conversion hook, so int(ranker) would raise TypeError: __int__ returned non-int (type NoneType). Since the base class has no state to initialize, the method can simply be removed.
2. join_fn is annotated with Embedding but receives an EmbeddableItem
The handler's input/output type is EmbeddableItem (InputT/OutputT in the same module), and Embedding has no metadata attribute. The annotation should be EmbeddableItem for both the parameter and the return type.
Neither issue changes runtime behavior for current users; the fix is a small cleanup. I plan to send a PR.
I've opened #40475 with the fix for both items. @claudevdm, since you've reviewed the recent ml.rag changes, could you take a look when you have a chance? Thanks!
Activity
pangwangshu commentedon Oct 9, 2026
.take-issue
pangwangshu commentedon Oct 9, 2026
I've opened #40475 with the fix for both items. @claudevdm, since you've reviewed the recent ml.rag changes, could you take a look when you have a chance? Thanks!
[Python] Fix __int__ typo and join_fn type hints in Milvus search han…