Skip to content

[AURON #2499] perf: avoid identity take in GenerateExec #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slfan1989 merged 2 commits into from
Sep 5, 2026
Merged

[AURON #2499] perf: avoid identity take in GenerateExec #2500

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeaf8b4
perf: avoid identity take in GenerateExec
lyne7-sc Sep 1, 2026
c26475c
docs: clarify GenerateExec identity range comment
lyne7-sc Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion native-engine/datafusion-ext-plans/src/generate_exec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,9 +274,13 @@ fn execute_generate(
let generated_ids = generated_ids.finish();
let child_outputs = take_cols(&child_outputs, child_output_row_ids)?;
let generated_outputs = match generated_outputs {
Some(generated_outputs) => {
Some(generated_outputs) if outer => {
take_cols(&generated_outputs.cols, generated_ids)?
}
// When outer is false, generated_ids is the identity sequence
// 0..generated_outputs.row_ids.len(). Reuse the generated arrays
// instead of copying them through Arrow take.
Some(generated_outputs) => generated_outputs.cols,
None => generator_output_schema
.fields()
.iter()
Expand Down
Loading