[AURON #2485] Support last_day function natively - #2486
Merged
Conversation
Sigma-Ma
force-pushed
the
Auron-2485-last-day-native
branch
from
August 29, 2026 14:46
a3c8f4e to
9fd678c
Compare
slfan1989
approved these changes
Aug 30, 2026
slfan1989
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding native support for last_day. I reviewed the expression conversion, function registration, native implementation, and test coverage. The implementation correctly handles month boundaries, leap years, pre-epoch dates, and null values. All checks are passing. LGTM!
Contributor
|
@Sigma-Ma Thanks for the contribution! Merged into master. |
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2485
Rationale for this change
Spark
last_dayexpressions cannot currently be converted to native expressions, causing affected plans to fall back to Spark execution.What changes are included in this PR?
LastDayexpressions to theSpark_LastDayextension function.Spark_LastDayusing the existing Date32 conversion and month-length helpers.Are there any user-facing changes?
No. The Spark SQL syntax and result semantics remain unchanged. Eligible
last_dayexpressions can now run natively.How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)
ASF guidance: https://www.apache.org/legal/generative-tooling.html