Skip to content

[AURON #2451] Add Paimon COW multi-commit correctness coverage - #2452

Merged
slfan1989 merged 3 commits into
apache:masterfrom
weimingdiit:test/paimon-cow-upsert-correctness
Aug 15, 2026
Merged

[AURON #2451] Add Paimon COW multi-commit correctness coverage#2452
slfan1989 merged 3 commits into
apache:masterfrom
weimingdiit:test/paimon-cow-upsert-correctness

Conversation

@weimingdiit

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #2451

Rationale for this change

The existing Paimon COW test verifies only a single commit. It does not protect against stale rows being returned after a later commit updates an existing primary key.

This change adds multi-commit correctness coverage while keeping the native scan implementation unchanged.

What changes are included in this PR?

Updates the existing Paimon COW primary-key integration test to:

  • Write the initial rows.
  • Write a newer value for an existing primary key in a second commit.
  • Verify that only the latest value is returned.
  • Verify that the query still uses NativePaimonV2TableScan.

Are there any user-facing changes?

No user-facing changes.

How was this patch tested?

UT.

Signed-off-by: weimingdiit <weimingdiit@gmail.com>
@weimingdiit
weimingdiit force-pushed the test/paimon-cow-upsert-correctness branch from 1b655c2 to 61fcc87 Compare August 8, 2026 04:05
@weimingdiit
weimingdiit marked this pull request as ready for review August 9, 2026 02:48
weimingdiit and others added 2 commits August 15, 2026 13:27
…/AuronPaimonV2IntegrationSuite.scala

Co-authored-by: Weiqing Yang <yangweiqing001@gmail.com>
Signed-off-by: weimingdiit <weimingdiit@gmail.com>
@slfan1989 slfan1989 self-assigned this Aug 15, 2026

@slfan1989 slfan1989 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback. The test now explicitly verifies that the query uses the native Paimon scan after compaction, while also confirming that only the latest value is returned across multiple commits. The updated coverage looks good to me. LGTM.

@slfan1989
slfan1989 merged commit 91ced1f into apache:master Aug 15, 2026
123 checks passed
@slfan1989

Copy link
Copy Markdown
Contributor

@weimingdiit Thanks for the contribution! @weiqingy Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Paimon COW multi-commit correctness coverage

3 participants