[AURON #2446] Flush buffered data based on row count - #2447
Merged
Conversation
slfan1989
approved these changes
Jul 31, 2026
slfan1989
left a comment
slfan1989
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution! compute_suggested_batch_size_for_output returns a row-count threshold, so comparing it with staging_num_rows fixes the unit mismatch. The regression test also clearly distinguishes the old byte-based behavior from the intended row-based behavior. The changes look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2446
this PR is to fix the incorrect flushing logic, that should be based on the row count rather than the bytes
Rationale for this change
Without this fix, the flushing will be triggered too frequently.
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)