Skip to content

ATLAS-5379 : Authorize lineage neighbor entities before returning headers #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VinayakMarraiya230920 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ATLAS-5379 : Authorize lineage neighbor entities before returning headers #731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,31 +654,40 @@ private void processEdge(final AtlasEdge edge, final Map<String, AtlasEntityHead
String relationGuid = AtlasGraphUtilsV2.getEncodedProperty(edge, RELATIONSHIP_GUID_PROPERTY_KEY, String.class);
boolean isInputEdge = edge.getLabel().equalsIgnoreCase(PROCESS_INPUTS_EDGE);

if (!entities.containsKey(inGuid)) {
AtlasEntityHeader entityHeader = entityRetriever.toAtlasEntityHeader(inVertex);
addEntityHeaderIfAuthorized(inVertex, inGuid, entities);
addEntityHeaderIfAuthorized(outVertex, outGuid, entities);

entities.put(inGuid, entityHeader);
if (entities.containsKey(inGuid) && entities.containsKey(outGuid)) {
if (isInputEdge) {
relations.add(new LineageRelation(inGuid, outGuid, relationGuid));
} else {
relations.add(new LineageRelation(outGuid, inGuid, relationGuid));
}
}

if (!entities.containsKey(outGuid)) {
AtlasEntityHeader entityHeader = entityRetriever.toAtlasEntityHeader(outVertex);
if (visitedEdges != null) {
String visitedEdgeLabel = isInputEdge ? getVisitedEdgeLabel(inGuid, outGuid, relationGuid) : getVisitedEdgeLabel(outGuid, inGuid, relationGuid);

entities.put(outGuid, entityHeader);
visitedEdges.add(visitedEdgeLabel);
}
}

if (isInputEdge) {
relations.add(new LineageRelation(inGuid, outGuid, relationGuid));
} else {
relations.add(new LineageRelation(outGuid, inGuid, relationGuid));
private void addEntityHeaderIfAuthorized(AtlasVertex vertex, String guid, Map<String, AtlasEntityHeader> entities) throws AtlasBaseException {
if (entities.containsKey(guid)) {
return;
}

if (visitedEdges != null) {
String visitedEdgeLabel = isInputEdge ? getVisitedEdgeLabel(inGuid, outGuid, relationGuid) : getVisitedEdgeLabel(outGuid, inGuid, relationGuid);
AtlasEntityHeader entityHeader = entityRetriever.toAtlasEntityHeader(vertex);

visitedEdges.add(visitedEdgeLabel);
if (isEntityReadAllowed(entityHeader)) {
entities.put(guid, entityHeader);
}
}

private boolean isEntityReadAllowed(AtlasEntityHeader entityHeader) {
return AtlasAuthorizationUtils.isAccessAllowed(new AtlasEntityAccessRequest(atlasTypeRegistry, AtlasPrivilege.ENTITY_READ, entityHeader));
}

private AtlasLineageInfo getBothLineageInfoV1(String guid, int depth, boolean isDataSet) throws AtlasBaseException {
AtlasLineageInfo inputLineage = getLineageInfo(guid, INPUT, depth, isDataSet);
AtlasLineageInfo outputLineage = getLineageInfo(guid, OUTPUT, depth, isDataSet);
Expand Down