ATLAS-5068: Improve Unit Test Coverage for Hive-bridge Module by aditya-gupta36 · Pull Request #425 · apache/atlas

aditya-gupta36 · 2025-08-12T14:40:33Z

What changes were proposed in this pull request?

Added Unit TCs for Hive module

How was this patch tested?

CI Build
PC Build: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1966/
mvn clean install and verify build locally (both success)
docker run locally

Copilot

Pull Request Overview

This pull request adds comprehensive unit test coverage for the Hive-bridge module, implementing test classes for core event handling functionality. The goal is to improve test coverage by adding unit tests for the most critical classes in the hive-bridge module.

Added unit tests for 6 core Hive event classes including DropTable, DropDatabase, CreateTable, CreateHiveProcess, CreateDatabase, and BaseHiveEvent
Implemented comprehensive test scenarios covering constructor validation, notification message generation, entity processing, and edge cases
Added helper methods and mock setups to support complex testing scenarios with proper isolation

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
DropTableTest.java	Tests for table deletion events including metastore and non-metastore hook scenarios, entity qualification, and integration workflows
DropDatabaseTest.java	Tests for database deletion events covering both metastore and hive entity processing paths with various edge cases
CreateTableTest.java	Comprehensive tests for table creation events including DDL operations, external tables, HBase integration, and reflection-based private method testing
CreateHiveProcessTest.java	Tests for Hive process creation covering lineage processing, column lineage, DDL operations, and complex workflow scenarios
CreateDatabaseTest.java	Tests for database creation events including metastore hook scenarios and entity generation
BaseHiveEventTest.java	Extensive tests for the base event class covering utility methods, entity processing, qualified name generation, and constant validation

Copilot · 2025-08-12T15:18:31Z

+        verify(context, times(1)).removeFromKnownTable(any(String.class));
+    }
+
+/*    @Test


Remove commented-out test method or uncomment and implement it properly. Commented code reduces maintainability.

Suggested change

/* @Test

@Test

Copilot · 2025-08-12T15:18:32Z

+        assertEquals(1, notifications.size());
+        assertTrue(notifications.get(0) instanceof EntityDeleteRequestV2);
+
+//        verify(context).removeFromKnownDatabase(anyString());


Remove commented-out verification code or uncomment it if the verification is needed for the test.

Suggested change

// verify(context).removeFromKnownDatabase(anyString());

verify(context).removeFromKnownDatabase(anyString());

Copilot · 2025-08-12T15:18:32Z

+    }
+
+    // =================== getHiveMetastoreEntities Tests ===================
+/*    @Test


Multiple commented-out test methods should be removed or properly implemented. This reduces code maintainability and can cause confusion.

Copilot · 2025-08-12T15:18:32Z

+        // So we should get null result due to skipProcess logic
+        AssertJUnit.assertNull("Entities should be null for self lineage scenario", entities);
+    }*/
+


Large block of commented-out test code should be removed to improve maintainability.

Suggested change

Copilot · 2025-08-12T15:18:32Z

+import org.apache.atlas.type.AtlasTypeUtil;
+import org.apache.hadoop.hive.metastore.IHMSHandler;
+import org.apache.hadoop.hive.metastore.api.Database;
+//import org.apache.hadoop.hive.metastore.api.DatabaseType;


Remove unused commented import statement.

Suggested change

//import org.apache.hadoop.hive.metastore.api.DatabaseType;

Copilot · 2025-08-12T15:18:33Z

+import java.util.*;
+
+import static org.mockito.Mockito.*;
+import static org.junit.Assert.assertNotNull;


[nitpick] Mixed usage of TestNG and JUnit assertions. The file primarily uses TestNG's AssertJUnit but also imports JUnit's Assert. Consider standardizing on one assertion library for consistency.

Suggested change

import static org.junit.Assert.assertNotNull;

Copilot · 2025-08-12T15:18:33Z

+        when(database.getOwnerType()).thenReturn(PrincipalType.USER);
+
+        when(database.getCatalogName()).thenReturn("hive");
+//        when(database.getCreateTime()).thenReturn(1753349206);


Remove commented-out mock setup code or uncomment it if needed for the test.

Suggested change

// when(database.getCreateTime()).thenReturn(1753349206);

Copilot · 2025-08-12T15:18:33Z

+
+
+
+   /* @Test


Multiple large blocks of commented-out test methods should be removed to improve code maintainability.

mneethiraj · 2025-08-12T16:28:08Z

@aditya-gupta36 - the build fails with the following error. Please review and update.

atlas-build  | [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.13:check (rat-check) on project hive-bridge: Too many files with unapproved license: 10 See RAT report in: /home/atlas/src/addons/hive-bridge/target/rat.txt -> [Help 1]
atlas-build  | [ERROR] 
atlas-build  | [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
atlas-build  | [ERROR] Re-run Maven using the -X switch to enable full debug logging.
atlas-build  | [ERROR] 
atlas-build  | [ERROR] For more information about the errors and possible solutions, please read the following articles:
atlas-build  | [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
atlas-build  | [ERROR] 
atlas-build  | [ERROR] After correcting the problems, you can resume the build with the command
atlas-build  | [ERROR]   mvn <args> -rf :hive-bridge

aditya-gupta36 · 2025-08-12T20:08:29Z

@mneethiraj Sir, Thanks for Feedback and update. Will look into it.

(cherry picked from commit 0e87796)

mneethiraj requested a review from Copilot August 12, 2025 15:15

Copilot AI reviewed Aug 12, 2025

View reviewed changes

aditya-gupta36 force-pushed the ATLAS-5068 branch from 11d0f09 to 724e163 Compare August 13, 2025 10:48

pareshddevalia suggested changes Aug 20, 2025

View reviewed changes

Comment thread addons/hive-bridge/pom.xml

pareshddevalia suggested changes Aug 20, 2025

View reviewed changes

Comment thread addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java Outdated

ATLAS-5068: Improve Unit Test Coverage for Hive-bridge Module

ee25388

aditya-gupta36 force-pushed the ATLAS-5068 branch from 724e163 to ee25388 Compare August 25, 2025 10:02

mandarambawane approved these changes Aug 29, 2025

View reviewed changes

mandarambawane merged commit 0e87796 into apache:master Aug 30, 2025
1 check passed

mandarambawane pushed a commit that referenced this pull request Feb 25, 2026

ATLAS-5068: Improve Unit Test Coverage for Hive-bridge Module (#425)

988bbf0

(cherry picked from commit 0e87796)

Navigation Menu

Uh oh!

ATLAS-5068: Improve Unit Test Coverage for Hive-bridge Module - #425

ATLAS-5068: Improve Unit Test Coverage for Hive-bridge Module#425
mandarambawane merged 1 commit into
apache:masterfrom
aditya-gupta36:ATLAS-5068

aditya-gupta36 commented Aug 12, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 12, 2025

Uh oh!

Copilot AI Aug 12, 2025

Uh oh!

Copilot AI Aug 12, 2025

Uh oh!

Copilot AI Aug 12, 2025

Uh oh!

Copilot AI Aug 12, 2025

Uh oh!

Copilot AI Aug 12, 2025

Uh oh!

Copilot AI Aug 12, 2025

Uh oh!

Copilot AI Aug 12, 2025

Uh oh!

mneethiraj commented Aug 12, 2025

Uh oh!

aditya-gupta36 commented Aug 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	// verify(context).removeFromKnownDatabase(anyString());
	verify(context).removeFromKnownDatabase(anyString());

Uh oh!

Conversation

aditya-gupta36 commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

How was this patch tested?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

mneethiraj commented Aug 12, 2025

Uh oh!

aditya-gupta36 commented Aug 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aditya-gupta36 commented Aug 12, 2025 •

edited

Loading