ATLAS-5059: add support for rdbms backend and audit repository - #405
Merged
Conversation
mneethiraj
requested review from
DishaTalreja3,
ashutoshm,
Copilot,
pinal-shah,
rameeshm,
rkundam and
sarathsubramanian
July 19, 2025 04:56
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive support for using Postgres as the RDBMS backend for JanusGraph storage and entity-audit repository, replacing HBase with a relational database solution.
- Implementation of RDBMS-based storage layer with JPA/PostgreSQL integration
- Addition of unique key handler for RDBMS backend to maintain data consistency
- Extension of entity audit repository to support RDBMS storage instead of HBase
- Docker configuration updates to support both HBase and Postgres deployment options
Reviewed Changes
Copilot reviewed 54 out of 54 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| AtlasGraphUtilsV2.java | Integrates unique key handler for RDBMS property management |
| DeleteHandlerV1.java | Adds unique key cleanup during graph element deletion |
| GraphBackedSearchIndexer.java | Implements unique index key tracking and RDBMS-specific handling |
| RdbmsBasedAuditRepository.java | New audit repository implementation using RDBMS instead of HBase |
| janusgraph-rdbms module | Complete new module providing JanusGraph RDBMS backend implementation |
| Docker configurations | Updated to support both HBase and Postgres backend deployment options |
Comments suppressed due to low confidence (2)
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java:52
- The method calls uniqueKeyHandler.removeUniqueKey with incorrect parameter order. The method signature expects (keyName, value, elementId, isVertex) but it's being called with (elementId, keyName, value) at line 57.
import org.apache.atlas.type.AtlasType;
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java:84
- The method calls uniqueKeyHandler.removeTypeUniqueKey with incorrect parameter order. The method signature expects (typeName, keyName, value, elementId, isVertex) but it's being called with (elementId, typeName, keyName, value) based on the pattern seen in RdbmsUniqueKeyHandler.
import static org.apache.atlas.repository.Constants.CLASSIFICATION_NAME_DELIMITER;
|
|
||
| @Override | ||
| public Set<String> getEntitiesWithTagChanges(long fromTimestamp, long toTimestamp) throws AtlasBaseException { | ||
| // TODO: |
There was a problem hiding this comment.
Method getEntitiesWithTagChanges contains only a TODO comment and returns an empty set. This incomplete implementation may cause issues if this functionality is required by the audit system.
…d scripts - INSERT statements updated to use the DEFAULT value specified in DDL
pinal-shah
approved these changes
Sep 9, 2025
mneethiraj
added a commit
that referenced
this pull request
Sep 14, 2025
(cherry picked from commit 0c5d667)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
enhancements to support using Postgres as the backend store for JanusGraph and entity-audit, replacing HBase
How was this patch tested?
starts up successfully with configuration set to use Postgres as the backend storage
successfully processes notifications, which stores the data in Postgres
successfully serve search APIs