ATLAS-4889: Incremental export : When an entity has tag propagated an… - #399
Open
chaitalicod wants to merge 2 commits into
Open
ATLAS-4889: Incremental export : When an entity has tag propagated an…#399chaitalicod wants to merge 2 commits into
chaitalicod wants to merge 2 commits into
Conversation
pareshddevalia
suggested changes
Jul 14, 2025
chaitalicod
force-pushed
the
ATLAS-4889
branch
2 times, most recently
from
July 18, 2025 05:12
467776e to
ba999c3
Compare
chaitalicod
force-pushed
the
ATLAS-4889
branch
10 times, most recently
from
November 12, 2025 12:41
0741f29 to
3723718
Compare
…nd is exported , the tag is not propagated to it in the export.
chaitalicod
force-pushed
the
ATLAS-4889
branch
from
November 13, 2025 05:26
3723718 to
fb22470
Compare
rkundam
approved these changes
Jun 25, 2026
rkundam
reviewed
Jun 26, 2026
| if (CollectionUtils.isNotEmpty(classifications)) { | ||
| for (AtlasClassification classification : classifications) { | ||
| String classificationName = classification.getTypeName(); | ||
| boolean isProcess = relationshipAttributesExtractor.isLineageType(entityTypeName); |
Contributor
There was a problem hiding this comment.
Lines 466 to 469 can be moved out of for loop
rkundam
reviewed
Jun 26, 2026
| adjacentVertex = StringUtils.equals(outVertex.getIdForDisplay(), entityVertex.getIdForDisplay()) ? inVertex : outVertex; | ||
| String adjacentGuid = getGuid(adjacentVertex); | ||
| boolean isPropagated = false; | ||
| propagateClassificationVertices = getClassificationVertices(inVertex, outVertex, isProcess, true, classificationName); |
Contributor
There was a problem hiding this comment.
The code in lines 477–485 is redundant with the code in lines 487–496. Consider extracting the shared logic into a single helper method.
| context.newAddedGuids.add(adjacentGuid); | ||
| } | ||
| if (!context.sink.guids.contains(adjacentGuid)) { | ||
| context.addToSink(entityGraphRetriever.toAtlasEntityWithExtInfo(adjacentGuid)); |
Contributor
There was a problem hiding this comment.
Isn't it necessary to exportTypeProcessor.addTypes before addToSink
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d is exported , the tag is not propagated to it in the export.
What changes were proposed in this pull request?
STEPS TO REPRODUCE:
Create table1
Create lineage CTAS tables of depth 10 ( t1 -> t2 -> t3 ..... t10)
Associate tag tag1 to table1
Export table table10
Import the zip
CURRENT BEHAVIOUR:
table10 doesn't have the tag associated to the it since the "entityGUID" is of table1's and table1 is not exported
EXPECTED BEHAVIOUR:
table10 should have tag1 exported
Proposed solution:
While exported we will fetch lineage from table10 backtracking till table1 or corresponding parent
On import user will have child as well as entire lineage till parent which will not break current logic
-Tag is propagated to child on import only if parent is present
How was this patch tested?
Combinations of Tag propagation,Blocktagpropagation feature
Tested with below lineage where multiple incoming edges are present