Skip to content

Atlas-5063: [Backend] Fix for improving logout mechanism in Atlas Backend code base - #397

Open
aditya-gupta36 wants to merge 1 commit into
apache:masterfrom
aditya-gupta36:Atlas-5063
Open

Atlas-5063: [Backend] Fix for improving logout mechanism in Atlas Backend code base#397
aditya-gupta36 wants to merge 1 commit into
apache:masterfrom
aditya-gupta36:Atlas-5063

Conversation

@aditya-gupta36

@aditya-gupta36 aditya-gupta36 commented Jul 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

This PR improves the Knox logout behavior in Apache Atlas.

  1. Previously, logging out of Atlas when accessed via Knox led to a blank page.
  2. To handle this, a new checkSso API was introduced to determine if the session is SSO-based by checking the presence of the hadoop-jwt cookie.
  3. Based on the response (true or false), the frontend now redirects either to a default action page (for SSO sessions) or to the traditional login.jsp.
  4. Additionally, a CustomLogoutSuccessHandler has been added for proper logout handling. Changes were also made to AtlasKnoxSSOAuthenticationFilter to support this logic.
  5. Some changes were done in AtlasSecurityConfig for logout.

How was this patch tested?

  1. Unit Test added
  2. UI testing - cluster: http://ccycloud-1.fsknox.root.comops.site:7180/cmf/home
  3. CI Build - Passed
  4. PC: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1933/

pareshddevalia
pareshddevalia suggested changes Jul 8, 2025
View reviewed changes
Comment thread webapp/src/main/java/org/apache/atlas/web/filters/RestUtil.java Outdated
Comment thread webapp/src/main/java/org/apache/atlas/web/security/CustomLogoutSuccessHandler.java Outdated
Comment thread webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java Outdated
Comment thread webapp/src/test/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilterTest.java
Comment thread webapp/src/main/java/org/apache/atlas/web/security/CustomLogoutSuccessHandler.java
@aditya-gupta36
aditya-gupta36 force-pushed the Atlas-5063 branch 2 times, most recently from dc63275 to 960ced0 Compare July 9, 2025 08:03
@aditya-gupta36 aditya-gupta36 changed the title Atlas[Backend] Fix for improving logout mechanism in Atlas Backend code base Atlas-5063: [Backend] Fix for improving logout mechanism in Atlas Backend code base Jul 10, 2025
pareshddevalia
pareshddevalia suggested changes Jul 21, 2025
View reviewed changes
Comment thread webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java Outdated
Comment thread webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java Outdated
Comment thread webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java Outdated
pareshddevalia
pareshddevalia suggested changes Jul 21, 2025
View reviewed changes
Comment thread webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chaitalicod chaitalicod chaitalicod left review comments
+1 more reviewer
@pareshddevalia pareshddevalia pareshddevalia requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aditya-gupta36 @chaitalicod @pareshddevalia