Skip to content

ATLAS-5055: Incremental Export : When entity exported has a tag propa… #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaitalicod merged 2 commits into from
Jul 29, 2025
Merged

ATLAS-5055: Incremental Export : When entity exported has a tag propa… #377

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a4de7c
ATLAS-5055: Incremental Export : When entity exported has a tag propa…
Jun 18, 2025
01a700f
Merge branch 'apache:master' into ATLAS-5055
chaitalicod Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...sitory/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@
package org.apache.atlas.repository.store.graph.v2;

import com.fasterxml.jackson.core.type.TypeReference;
import org.apache.atlas.AtlasConfiguration;
import org.apache.atlas.AtlasErrorCode;
import org.apache.atlas.RequestContext;
import org.apache.atlas.exception.AtlasBaseException;
import org.apache.atlas.model.TimeBoundary;
import org.apache.atlas.model.glossary.AtlasGlossaryCategory;
Expand Down Expand Up @@ -162,6 +164,7 @@ public class EntityGraphRetriever {
private static final String GLOSSARY_CATEGORY_HIERARCHY_EDGE_LABEL = "r:AtlasGlossaryCategoryHierarchyLink";
private static final String GLOSSARY_CATEGORY_TYPE_NAME = AtlasGlossaryCategory.class.getSimpleName();
private static final String PARENT_GLOSSARY_CATEGORY_GUID = "parentCategoryGuid";
private boolean deferredActionEnabled = AtlasConfiguration.TASKS_USE_ENABLED.getBoolean();

private static final TypeReference<List<TimeBoundary>> TIME_BOUNDARIES_LIST_TYPE = new TypeReference<List<TimeBoundary>>() {};

Expand Down Expand Up @@ -698,7 +701,7 @@ private void traverseImpactedVertices(final AtlasVertex entityVertexStart, final
Iterable<AtlasEdge> propagationEdges = entityVertex.getEdges(AtlasEdgeDirection.BOTH, tagPropagationEdges);

for (AtlasEdge propagationEdge : propagationEdges) {
if (getEdgeStatus(propagationEdge) != ACTIVE) {
if (getEdgeStatus(propagationEdge) != ACTIVE && !deferredActionEnabled && !RequestContext.get().isImportInProgress()) {

@mneethiraj mneethiraj Aug 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaitalicod - with addition of && !deferredActionEnabled here, tags from deleted entities will be propagated even when import is not in progress. Note that the default value of AtlasConfiguration.TASKS_USE_ENABLED is true, which will result in the if at line 704 evaluate to false, hence will continue with propagation. This does not look correct. Can you please validate?

@mneethiraj mneethiraj Aug 18, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaitalicod - when deferredActionEnabled is true, this if condition will evaluate to false, hence will continue to propagate classification - even when getEdgeStatus(propagationEdge) is not ACTIVE i.e. deleted edge. This doesn't seem correct.

@chaitalicod chaitalicod Sep 8, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mneethiraj ,
Sorry for late response I was working on this comment I have changed my approach and created a PR
#434
Kindly review

continue;
}

Expand Down